Issue 6279 - Make HashContainer movable and optimize resizing by moving entries.

compiled/StringMap.h

Index: compiled/StringMap.h
===================================================================
--- a/compiled/StringMap.h
+++ b/compiled/StringMap.h
@@ -48,16 +48,19 @@
   struct StringSetEntry
   {
     typedef Key key_type;
     typedef const String& key_type_cref;
     typedef size_t size_type;
 
     key_type first;
 
+    StringSetEntry& operator=(const StringSetEntry&) = default;
+    StringSetEntry& operator=(StringSetEntry&&) = default;

[sergei, 2018/01/24 18:37:12]

It seems it's actually not required here and in StringMapEntry, because at least
all requirements for implicitly generated constructor and assignment operator
are satisfied.
http://en.cppreference.com/w/cpp/language/copy_assignment and others.

[hub, 2018/01/24 19:32:01]

ah right.

Done

[sergei, 2018/01/25 10:55:07]

Could you please also do it for StringMapEntry below?

[hub, 2018/01/25 15:11:11]

Done.

(I was convinced they were needed, must have been a side effect, done now)

+
     StringSetEntry(key_type_cref key = key_type())
     {
       if (!key.is_invalid())
         first.reset(key);
     }
 
     bool equals(key_type_cref other) const
     {
@@ -88,19 +91,22 @@
   template<typename Key, typename Value>
   struct StringMapEntry : StringSetEntry<Key>
   {
     typedef StringSetEntry<Key> super;
     typedef Value value_type;
 
     value_type second;
 
+    StringMapEntry& operator=(const StringMapEntry&) = default;
+    StringMapEntry& operator=(StringMapEntry&&) = default;
+
     StringMapEntry(typename super::key_type_cref key = Key(),
                    value_type value = value_type())
-        : super(key), second(value)
+       : super(key), second(std::move(value))
     {
     }
 
     void erase()
     {
       super::erase();
       second = value_type();
     }