libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java - Issue 29678590: Issue 6307 - Introduce external engine created callback

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java

Issue 29678590: Issue 6307 - Introduce external engine created callback (Closed)

Patch Set: Created Jan. 24, 2018, 12:46 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « libadblockplus-android-settings/build.gradle ('k') | libadblockplus-android-webviewapp/build.gradle » ('j') | libadblockplus-android-webviewapp/src/org/adblockplus/libadblockplus/android/webviewapp/Application.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java

diff --git a/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java b/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java

index 01fda611982a2c601533861ad299113236913228..bb511a6fe6b4835f76ca265bd08c595cbc7d7f39 100644

--- a/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java

+++ b/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java

@@ -148,8 +148,8 @@ public class AdblockHelper

private void initProvider(Context context, String basePath, boolean developmentBuild)

{

provider = new SingleInstanceEngineProvider(context, basePath, developmentBuild);

- provider.setEngineCreatedCallback(engineCreatedCallback);

- provider.setEngineDisposedCallback(engineDisposedCallback);

+ provider.addEngineCreatedCallback(engineCreatedCallback);

+ provider.addEngineDisposedCallback(engineDisposedCallback);

}

private void initStorage(Context context, String settingsPreferenceName)