Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29678669: Noissue - add withNAD for tests (Closed)

Created:
Jan. 24, 2018, 7:10 p.m. by sergei
Modified:
Jan. 25, 2018, 10:59 a.m.
Reviewers:
hub
Base URL:
github.com:adblockplus/adblockpluscore
Visibility:
Public.

Description

withNAD is short form from withNativeArgumentDeletion, it wraps the function with the code deleting native arguments, what significantly simplifies the code at least by minimizing the number of lines. Review: https://codereview.adblockplus.org/29678669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
A test/_test-utils.js View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 2
sergei
Jan. 24, 2018, 7:13 p.m. (2018-01-24 19:13:30 UTC) #1
hub
Jan. 24, 2018, 9:13 p.m. (2018-01-24 21:13:02 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld