Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1224)

Issue 29679796: Issue 6298 - Split injected CSS hiding rule into groups of 1,024 selectors (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Manish Jethani
Modified:
1 year, 5 months ago
Reviewers:
Sebastian Noack, kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Patch Set 1 #

Total comments: 7

Patch Set 2 : Increase group size to 1,024 #

Patch Set 3 : Use generator functions #

Patch Set 4 : Update comment explaining why we split the selectors into groups of 1,024 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -7 lines) Patch
M include.preload.js View 1 2 3 2 chunks +12 lines, -6 lines 0 comments Download
M lib/cssInjection.js View 1 2 3 2 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 12
Manish Jethani
1 year, 5 months ago (2018-01-25 17:12:33 UTC) #1
Manish Jethani
Patch Set 1 https://codereview.adblockplus.org/29679796/diff/29679797/include.preload.js File include.preload.js (right): https://codereview.adblockplus.org/29679796/diff/29679797/include.preload.js#newcode433 include.preload.js:433: // Chromium's Blink engine supports only ...
1 year, 5 months ago (2018-01-25 17:15:03 UTC) #2
kzar
https://codereview.adblockplus.org/29679796/diff/29679797/lib/cssInjection.js File lib/cssInjection.js (right): https://codereview.adblockplus.org/29679796/diff/29679797/lib/cssInjection.js#newcode38 lib/cssInjection.js:38: // Chromium's Blink engine supports only up to 8,192 ...
1 year, 5 months ago (2018-01-25 17:46:47 UTC) #3
Manish Jethani
https://codereview.adblockplus.org/29679796/diff/29679797/lib/cssInjection.js File lib/cssInjection.js (right): https://codereview.adblockplus.org/29679796/diff/29679797/lib/cssInjection.js#newcode38 lib/cssInjection.js:38: // Chromium's Blink engine supports only up to 8,192 ...
1 year, 5 months ago (2018-01-25 18:42:42 UTC) #4
Manish Jethani
https://codereview.adblockplus.org/29679796/diff/29679797/lib/cssInjection.js File lib/cssInjection.js (right): https://codereview.adblockplus.org/29679796/diff/29679797/lib/cssInjection.js#newcode38 lib/cssInjection.js:38: // Chromium's Blink engine supports only up to 8,192 ...
1 year, 5 months ago (2018-01-25 18:44:28 UTC) #5
Manish Jethani
https://codereview.adblockplus.org/29679796/diff/29679797/lib/cssInjection.js File lib/cssInjection.js (right): https://codereview.adblockplus.org/29679796/diff/29679797/lib/cssInjection.js#newcode38 lib/cssInjection.js:38: // Chromium's Blink engine supports only up to 8,192 ...
1 year, 5 months ago (2018-01-30 06:19:43 UTC) #6
Manish Jethani
Patch Set 2: Increase group size to 1,024
1 year, 5 months ago (2018-01-30 06:31:32 UTC) #7
Manish Jethani
Patch Set 3: Use generator functions
1 year, 5 months ago (2018-01-30 07:07:10 UTC) #8
kzar_kzar.co.uk
https://codereview.adblockplus.org/29679796/diff/29679797/lib/cssInjection.js File lib/cssInjection.js (right): https://codereview.adblockplus.org/29679796/diff/29679797/lib/cssInjection.js#newcode38 lib/cssInjection.js:38: // Chromium's Blink engine supports only up to 8,192 ...
1 year, 5 months ago (2018-01-30 11:40:00 UTC) #9
Manish Jethani
https://codereview.adblockplus.org/29679796/diff/29679797/lib/cssInjection.js File lib/cssInjection.js (right): https://codereview.adblockplus.org/29679796/diff/29679797/lib/cssInjection.js#newcode38 lib/cssInjection.js:38: // Chromium's Blink engine supports only up to 8,192 ...
1 year, 5 months ago (2018-01-30 13:15:43 UTC) #10
Manish Jethani
Patch Set 4: Update comment explaining why we split the selectors into groups of 1,024 ...
1 year, 5 months ago (2018-01-30 13:41:03 UTC) #11
kzar
1 year, 5 months ago (2018-01-30 16:09:12 UTC) #12
Assuming you tested this it LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5