Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 29680581: Issue 6318 - Add translations (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by anton
Modified:
2 years ago
Reviewers:
jens, diegocarloslima
CC:
René Jeschke, vicky
Visibility:
Public.

Description

Issue 6318 - Add translations

Patch Set 1 #

Patch Set 2 : Removed region from Burmese language ("my-rMM" to "my") #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+432 lines, -0 lines) Patch
A libadblockplus-android-settings/res/values-bg/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-bn/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-bs/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-ca/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-cs/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-da/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-et/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-fi/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 4 comments Download
A libadblockplus-android-settings/res/values-iw/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-kk/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-km/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-lt/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-lv/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-mk/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-ms/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-my/adblock_settings_strings.xml View 1 1 chunk +18 lines, -0 lines 3 comments Download
A libadblockplus-android-settings/res/values-nb/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-nl/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-sk/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-sl/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-sr/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-sv/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download
A libadblockplus-android-settings/res/values-ur/adblock_settings_strings.xml View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8
anton
I've tried to follow http://hub.eyeo.com/issues/6895#note-2 but not limiting to the region (discussed with Vicky).
2 years ago (2018-01-26 07:55:59 UTC) #1
anton
On 2018/01/26 07:55:59, anton wrote: > I've tried to follow http://hub.eyeo.com/issues/6895#note-2 but not limiting to ...
2 years ago (2018-01-26 07:58:50 UTC) #2
jens
https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml File libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml (right): https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml#newcode4 libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml:4: <string name="fragment_adblock_settings_enabled_title">Adblock Plus</string> Not related to this file, but ...
2 years ago (2018-01-26 08:54:19 UTC) #3
anton
https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml File libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml (right): https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml#newcode4 libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml:4: <string name="fragment_adblock_settings_enabled_title">Adblock Plus</string> On 2018/01/26 08:54:19, jens wrote: > ...
2 years ago (2018-01-26 10:10:04 UTC) #4
jens
https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml File libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml (right): https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml#newcode4 libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml:4: <string name="fragment_adblock_settings_enabled_title">Adblock Plus</string> On 2018/01/26 10:10:04, anton wrote: > ...
2 years ago (2018-01-26 10:49:50 UTC) #5
jens
On 2018/01/26 10:49:50, jens wrote: > https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml > File libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml > (right): > > https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml#newcode4 ...
2 years ago (2018-01-26 10:49:59 UTC) #6
anton
https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml File libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml (right): https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml#newcode4 libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml:4: <string name="fragment_adblock_settings_enabled_title">Adblock Plus</string> On 2018/01/26 10:49:50, jens wrote: > ...
2 years ago (2018-01-26 11:45:25 UTC) #7
diegocarloslima
2 years ago (2018-01-26 11:59:13 UTC) #8
On 2018/01/26 11:45:25, anton wrote:
>
https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
> File
libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml
> (right):
> 
>
https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
> libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml:4:
> <string name="fragment_adblock_settings_enabled_title">Adblock Plus</string>
> On 2018/01/26 10:49:50, jens wrote:
> > On 2018/01/26 10:10:04, anton wrote:
> > > On 2018/01/26 08:54:19, jens wrote:
> > > > Not related to this file, but maybe we should add a summary for this
> setting
> > > in
> > > > the future, as the title is not very descriptive.
> > > 
> > > We could do it, but since you can just find where it's used (fn + option +
> f7)
> > > i'm not sure it worth it.
> > 
> > Sure, but still for people using the Settings without modifying anything
(and
> > also for consistency) we could add a summary.
> > But let's discuss that somewhere else, as it is not related to this issue.
> 
> sure, we can do it. Could you please create a ticket for this?

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5