Issue 6318 - Add translations

Issue 6318 - Add translations

[anton, 2018-01-26 07:55:59]

I've tried to follow http://hub.eyeo.com/issues/6895#note-2 but not limiting to
the region (discussed with Vicky).

[anton, 2018-01-26 07:58:50]

On 2018/01/26 07:55:59, anton wrote:
> I've tried to follow http://hub.eyeo.com/issues/6895#note-2 but not limiting
to
> the region (discussed with Vicky).

BTW should i inc versions in modules? If yes then it's tricky as it depends on
other code reviews.
It can happen that this code review will be applied and version will be
increased. And the other (pending) code review the version is also increased.
And if we apply that code review after this it will not increase version as it's
already increased here.

[jens, 2018-01-26 08:54:19]

https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
File libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml
(right):

https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml:4:
<string name="fragment_adblock_settings_enabled_title">Adblock Plus</string>
Not related to this file, but maybe we should add a summary for this setting in
the future, as the title is not very descriptive.

https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
File libadblockplus-android-settings/res/values-my/adblock_settings_strings.xml
(right):

https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
libadblockplus-android-settings/res/values-my/adblock_settings_strings.xml:17: 
Some of the characters are not displayed correctly. Is that only in Rietveld?

[anton, 2018-01-26 10:10:04]

https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
File libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml
(right):

https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml:4:
<string name="fragment_adblock_settings_enabled_title">Adblock Plus</string>
On 2018/01/26 08:54:19, jens wrote:
> Not related to this file, but maybe we should add a summary for this setting
in
> the future, as the title is not very descriptive.

We could do it, but since you can just find where it's used (fn + option + f7)
i'm not sure it worth it.

https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
File libadblockplus-android-settings/res/values-my/adblock_settings_strings.xml
(right):

https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
libadblockplus-android-settings/res/values-my/adblock_settings_strings.xml:17: 
On 2018/01/26 08:54:19, jens wrote:
> Some of the characters are not displayed correctly. Is that only in Rietveld?

it looks a bit different in Android Studio, but better:
https://drive.google.com/file/d/1diAP8PsYxjxEE4N2dvnC6qQulXL39Svr/view?usp=sh...

[jens, 2018-01-26 10:49:50]

https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
File libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml
(right):

https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml:4:
<string name="fragment_adblock_settings_enabled_title">Adblock Plus</string>
On 2018/01/26 10:10:04, anton wrote:
> On 2018/01/26 08:54:19, jens wrote:
> > Not related to this file, but maybe we should add a summary for this setting
> in
> > the future, as the title is not very descriptive.
> 
> We could do it, but since you can just find where it's used (fn + option + f7)
> i'm not sure it worth it.

Sure, but still for people using the Settings without modifying anything (and
also for consistency) we could add a summary.
But let's discuss that somewhere else, as it is not related to this issue.

https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
File libadblockplus-android-settings/res/values-my/adblock_settings_strings.xml
(right):

https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
libadblockplus-android-settings/res/values-my/adblock_settings_strings.xml:17: 
On 2018/01/26 10:10:04, anton wrote:
> On 2018/01/26 08:54:19, jens wrote:
> > Some of the characters are not displayed correctly. Is that only in
Rietveld?
> 
> it looks a bit different in Android Studio, but better:
>
https://drive.google.com/file/d/1diAP8PsYxjxEE4N2dvnC6qQulXL39Svr/view?usp=sh...

Yeah, that looks alright

[jens, 2018-01-26 10:49:59]

On 2018/01/26 10:49:50, jens wrote:
>
https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
> File
libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml
> (right):
> 
>
https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
> libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml:4:
> <string name="fragment_adblock_settings_enabled_title">Adblock Plus</string>
> On 2018/01/26 10:10:04, anton wrote:
> > On 2018/01/26 08:54:19, jens wrote:
> > > Not related to this file, but maybe we should add a summary for this
setting
> > in
> > > the future, as the title is not very descriptive.
> > 
> > We could do it, but since you can just find where it's used (fn + option +
f7)
> > i'm not sure it worth it.
> 
> Sure, but still for people using the Settings without modifying anything (and
> also for consistency) we could add a summary.
> But let's discuss that somewhere else, as it is not related to this issue.
> 
>
https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
> File
libadblockplus-android-settings/res/values-my/adblock_settings_strings.xml
> (right):
> 
>
https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
> libadblockplus-android-settings/res/values-my/adblock_settings_strings.xml:17:

> On 2018/01/26 10:10:04, anton wrote:
> > On 2018/01/26 08:54:19, jens wrote:
> > > Some of the characters are not displayed correctly. Is that only in
> Rietveld?
> > 
> > it looks a bit different in Android Studio, but better:
> >
>
https://drive.google.com/file/d/1diAP8PsYxjxEE4N2dvnC6qQulXL39Svr/view?usp=sh...
> 
> Yeah, that looks alright

LGTM

[anton, 2018-01-26 11:45:25]

https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
File libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml
(right):

https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml:4:
<string name="fragment_adblock_settings_enabled_title">Adblock Plus</string>
On 2018/01/26 10:49:50, jens wrote:
> On 2018/01/26 10:10:04, anton wrote:
> > On 2018/01/26 08:54:19, jens wrote:
> > > Not related to this file, but maybe we should add a summary for this
setting
> > in
> > > the future, as the title is not very descriptive.
> > 
> > We could do it, but since you can just find where it's used (fn + option +
f7)
> > i'm not sure it worth it.
> 
> Sure, but still for people using the Settings without modifying anything (and
> also for consistency) we could add a summary.
> But let's discuss that somewhere else, as it is not related to this issue.

sure, we can do it. Could you please create a ticket for this?

[diegocarloslima, 2018-01-26 11:59:13]

On 2018/01/26 11:45:25, anton wrote:
>
https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
> File
libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml
> (right):
> 
>
https://codereview.adblockplus.org/29680581/diff/29680607/libadblockplus-andr...
> libadblockplus-android-settings/res/values-hr/adblock_settings_strings.xml:4:
> <string name="fragment_adblock_settings_enabled_title">Adblock Plus</string>
> On 2018/01/26 10:49:50, jens wrote:
> > On 2018/01/26 10:10:04, anton wrote:
> > > On 2018/01/26 08:54:19, jens wrote:
> > > > Not related to this file, but maybe we should add a summary for this
> setting
> > > in
> > > > the future, as the title is not very descriptive.
> > > 
> > > We could do it, but since you can just find where it's used (fn + option +
> f7)
> > > i'm not sure it worth it.
> > 
> > Sure, but still for people using the Settings without modifying anything
(and
> > also for consistency) we could add a summary.
> > But let's discuss that somewhere else, as it is not related to this issue.
> 
> sure, we can do it. Could you please create a ticket for this?

LGTM