pages/index.html - Issue 29680647: Issue 5329 - Provide a template for social media meta data in website-defaults

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: pages/index.html

Issue 29680647: Issue 5329 - Provide a template for social media meta data in website-defaults (Closed) Base URL: https://hg.adblockplus.org/website-defaults

Patch Set: Created Jan. 26, 2018, 11:28 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 title=Website defaults	1 title=Website defaults

2 description=Default resources for eyeo websites	2 description=Default resources for eyeo websites

3 title_suffix=none	3 title_suffix=none

4	4

5 <h1>Website defaults</h1>	5 <h1>Website defaults</h1>

6 <p>Default resources for eyeo websites.</p>	6 <p>Default resources for eyeo websites.</p>

7	7

8 <h2>Components</h2>	8 <h2>Components</h2>

9	9

10 <ol>	10 <ol>

11 <li><a href="utilities">Utilities</a></li>	11 <li><a href="utilities">Utilities</a></li>

12 <li><a href="content">Content</a></li>	12 <li><a href="content">Content</a></li>

13 <li><a href="grid">Grid</a></li>	13 <li><a href="grid">Grid</a></li>

14 <li><a href="navbar">Navbar</a></li>	14 <li><a href="navbar">Navbar</a></li>

15 <li>	15 <li>

16 Forms	16 Forms

17 <ol>	17 <ol>

18 <li><a href="forms/basic">Basic form fields</a></li>	18 <li><a href="forms/basic">Basic form fields</a></li>

19 <li><a href="forms/advanced">Advanced form fields</a></li>	19 <li><a href="forms/advanced">Advanced form fields</a></li>

20 <li><a href="forms/buttons">Buttons</a></li>	20 <li><a href="forms/buttons">Buttons</a></li>

21 </ol>	21 </ol>

22 </li>	22 </li>

23 <li><a href="content-styleguide">Content Styleguide</a></li>	23 <li><a href="content-styleguide">Content Styleguide</a></li>
	juliandoucette 2018/01/30 04:04:41 Detail: I think it makes sense to separate these f Detail: I think it makes sense to separate these from "Components" if we are going to separate "Includes" (separately). "Components" was intended to be very general and encompass includes. Despite that, I'm not opposed to making "Components" into SCSS components or something more specific if it helps us organize things better. ire 2018/01/30 08:19:08 This makes sense. I think we should separate/organ Show quoted text On 2018/01/30 04:04:41, juliandoucette wrote: > Detail: I think it makes sense to separate these from "Components" if we are > going to separate "Includes" (separately). "Components" was intended to be very > general and encompass includes. Despite that, I'm not opposed to making > "Components" into SCSS components or something more specific if it helps us > organize things better. This makes sense. I think we should separate/organise these in a separate issue, could you create one please?
24 <li><a href="developer-styleguide">Developer Styleguide</a></li>	24 <li><a href="developer-styleguide">Developer Styleguide</a></li>

25 </ol>	25 </ol>

	26

	27 <h2>Includes</h2>

	28

	29 <ol>

	30 <li><a href="metadata">Metadata</a></li>

	31 </ol>

OLD	NEW

« includes/meta/social.tmpl ('K') | « includes/meta/social.tmpl ('k') | pages/metadata.md » ('j') | pages/metadata.md » ('J')