filters/to_og_locale.py - Issue 29680647: Issue 5329 - Provide a template for social media meta data in website-defaults

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: filters/to_og_locale.py

Issue 29680647: Issue 5329 - Provide a template for social media meta data in website-defaults (Closed) Base URL: https://hg.adblockplus.org/website-defaults

Left Patch Set: Created Jan. 26, 2018, 11:28 a.m.

Right Patch Set: Addressed NITs Created Feb. 1, 2018, 9:06 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 og_locales = {	1 og_locales = {

2 'ar': 'ar_AR',	2 'ar': 'ar_AR',

3 'bg': 'bg_BG',	3 'bg': 'bg_BG',

4 'de': 'de_DE',	4 'de': 'de_DE',

5 'dk': 'da_DK',	5 'da': 'da_DK',

6 'da': 'da_DK',	6 'en': 'en_US',

7 'en': 'en_US',	7 'es': 'es_ES',

8 'es': 'es_LA',	8 'es_MX': 'es_LA',

9 'fr': 'fr_FR',	9 'fr': 'fr_FR',

10 'el': 'el_GR',	10 'el': 'el_GR',

11 'he': 'he_IL',	11 'he': 'he_HE',

12 'hu': 'hu_HU',	12 'hu': 'hu_HU',

13 'it': 'it_IT',	13 'it': 'it_IT',

14 'ja': 'ja_JP',	14 'ms': 'ms_MY',

15 'ko': 'ko_KR',	15 'ja': 'ja_JP',

16 'lt': 'lt_LT',	16 'ko': 'ko_KR',

17 'nl': 'nl_NL',	17 'lt': 'lt_LT',

18 'pl': 'pl_PL',	18 'nl': 'nl_NL',

19 'pt': 'pt_PT',	19 'pl': 'pl_PL',

20 'pt_BR': 'pt_BR',	20 'pt': 'pt_PT',

21 'ro': 'ro_RO',	21 'pt_BR': 'pt_BR',

22 'ru': 'ru_RU',	22 'ru': 'ru_RU',

23 'sk': 'sk_SK',	23 'sk': 'sk_SK',

24 'sl': 'sl_SI',	24 'th': 'th_TH',

25 'sv': 'sv_SE',	25 'tr': 'tr_TR',

26 'tr': 'tr_TR',	26 'vi': 'vi_VN',

27 'vi': 'vi_VN',	27 'zh_CN': 'zh_CN',

28 'zh_CN': 'zh_CN',	28 'zh_TW': 'zh_TW',

29 'zh_TW': 'zh_TW',

30 }	29 }

31	30

32 def to_og_locale(locale):	31 def to_og_locale(locale):

33 return og_locales[locale]	32 return og_locales[locale] if locale in og_locales else locale
juliandoucette 2018/01/30 04:04:39 Please consider this future-proof implementation h Please consider this future-proof implementation https://hg.adblockplus.org/web.adblockplus.org/file/tip/filters/to_og_locale.py ire 2018/01/30 08:19:07 Done. Show quoted text On 2018/01/30 04:04:39, juliandoucette wrote: > Please consider this future-proof implementation > https://hg.adblockplus.org/web.adblockplus.org/file/tip/filters/to_og_locale.py Done.
LEFT	RIGHT