[$csp1 adblockpluscore] Issue 6329 - Allow whitespace in filter option values

lib/synchronizer.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 262 matching lines @@
     if (minVersion)
       subscription.requiredVersion = minVersion;
     else
       delete subscription.requiredVersion;
 
     // Process filters
     lines.shift();
     let filters = [];
     for (let line of lines)
     {
-      line = Filter.normalize(line);
+      line = Filter.stripJunk(line);

[Manish Jethani, 2018/02/05 16:09:58]

Since most of the code has moved out anyway, why not just move the rest of it
into Filter.fromText and get rid of Filter.stripJunk?

On the other hand, it seems like there might have been a good reason for
separating out the normalization from the rest of the parsing, since
Filter.normalize is called from only two places whereas Filter.fromText is
called from multiple places.

Anyway I'm in favor of simplifying this further and just keep everything in
Filter.fromText unless it's a performance concern.

[kzar, 2018/02/13 11:56:47]

Yea, perhaps we should do that if we continue with this approach. I wonder if
there's a better way, I quite like normalisation happening in separate step, but
it's a pain to allow the whitespace we need that way.

       if (line)
         filters.push(Filter.fromText(line));
     }
 
     FilterStorage.updateSubscriptionFilters(subscription, filters);
 
     return undefined;
   },
 
   _onDownloadError(downloadable, downloadURL, error, channelStatus,
@@ skipping 56 matching lines @@
               subscription.filters.map(f => f.text).join("\n");
             redirectCallback("data:text/plain," + encodeURIComponent(data));
           }
         }, false);
         request.send(null);
       }
     }
   }
 };
 Synchronizer.init();