metadata.chrome - Issue 29680696: [$csp4 adblockpluschrome] Issue 5241 - Add support for Content Security Policy filters

Side by Side Diff: metadata.chrome

Issue 29680696: [$csp4 adblockpluschrome] Issue 5241 - Add support for Content Security Policy filters (Closed)

Patch Set: Rebased, ignored requests cached by ServiceWorkers and addressed Sebastian's feedback Created March 13, 2018, 6:08 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 [general]	1 [general]

2 basename = adblockpluschrome	2 basename = adblockpluschrome

3 version = 3.0.2	3 version = 3.0.2

4 author = eyeo GmbH	4 author = eyeo GmbH

5 permissions = tabs	5 permissions = tabs

6 <all_urls>	6 <all_urls>

7 contextMenus	7 contextMenus

8 webRequest	8 webRequest

9 webRequestBlocking	9 webRequestBlocking

10 webNavigation	10 webNavigation

(...skipping 94 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
105 skin/updates/icon-mobile.svg = adblockplusui/skin/updates/icon-mobile.svg	105 skin/updates/icon-mobile.svg = adblockplusui/skin/updates/icon-mobile.svg

106 skin/updates/icon-rocket.svg = adblockplusui/skin/updates/icon-rocket.svg	106 skin/updates/icon-rocket.svg = adblockplusui/skin/updates/icon-rocket.svg

107 skin/updates/icon-thumbs-up.svg = adblockplusui/skin/updates/icon-thumbs-up.svg	107 skin/updates/icon-thumbs-up.svg = adblockplusui/skin/updates/icon-thumbs-up.svg

108 devtools-panel.html = adblockplusui/devtools-panel.html	108 devtools-panel.html = adblockplusui/devtools-panel.html

109 devtools-panel.js = adblockplusui/devtools-panel.js	109 devtools-panel.js = adblockplusui/devtools-panel.js

110 skin/devtools-panel.css = adblockplusui/skin/devtools-panel.css	110 skin/devtools-panel.css = adblockplusui/skin/devtools-panel.css

111 issue-reporter.html = adblockplusui/issue-reporter.html	111 issue-reporter.html = adblockplusui/issue-reporter.html

112 issue-reporter.js = adblockplusui/issue-reporter.js	112 issue-reporter.js = adblockplusui/issue-reporter.js

113 skin/issue-reporter.css = adblockplusui/skin/issue-reporter.css	113 skin/issue-reporter.css = adblockplusui/skin/issue-reporter.css

114 desktop-options.html = adblockplusui/desktop-options.html	114 desktop-options.html = adblockplusui/desktop-options.html

115 desktop-options.js = adblockplusui/desktop-options.js	115 desktop-options.js = adblockplusui/js/desktop-options.js
	Sebastian Noack 2018/03/13 22:28:31 This change seems unrelated. I first suspected it This change seems unrelated. I first suspected it to come from rebasing, but this change is not included in the current "next" bookmark. kzar 2018/03/14 10:46:43 This change is necessary since I updated the adblo Show quoted text On 2018/03/13 22:28:31, Sebastian Noack wrote: > This change seems unrelated. I first suspected it to come from rebasing, but > this change is not included in the current "next" bookmark. This change is necessary since I updated the adblockplusui dependency to include my $csp related changes. By the time this lands hopefully the dependency will have already been updated and this change won't be necessary. Sorry I thought I had left a comment to explain already. (No I'm not happy about #6310, we should instead combine adblockplusui and adblockpluschrome instead of introducing another module system in adblockplusui which apparently doesn't even give us source maps for the bundled UI code in our builds...) Sebastian Noack 2018/03/19 22:25:11 There is now a separate issue for the adblockplusu Show quoted text On 2018/03/14 10:46:43, kzar wrote: > On 2018/03/13 22:28:31, Sebastian Noack wrote: > > This change seems unrelated. I first suspected it to come from rebasing, but > > this change is not included in the current "next" bookmark. > > This change is necessary since I updated the adblockplusui dependency to include > my $csp related changes. By the time this lands hopefully the dependency will > have already been updated and this change won't be necessary. Sorry I thought I > had left a comment to explain already. There is now a separate issue for the adblockplusui depdency update (#6476). I marked it as blocking this change. kzar 2018/03/20 09:02:30 Acknowledged. When that lands I'll rebase this cha Show quoted text On 2018/03/19 22:25:11, Sebastian Noack wrote: > On 2018/03/14 10:46:43, kzar wrote: > > On 2018/03/13 22:28:31, Sebastian Noack wrote: > > > This change seems unrelated. I first suspected it to come from rebasing, but > > > this change is not included in the current "next" bookmark. > > > > This change is necessary since I updated the adblockplusui dependency to > include > > my $csp related changes. By the time this lands hopefully the dependency will > > have already been updated and this change won't be necessary. Sorry I thought > I > > had left a comment to explain already. > > There is now a separate issue for the adblockplusui depdency update (#6476). > I marked it as blocking this change. Acknowledged. When that lands I'll rebase this change on top.
116 skin/desktop-options.css = adblockplusui/skin/desktop-options.css	116 skin/desktop-options.css = adblockplusui/skin/desktop-options.css

117 updates.html = adblockplusui/updates.html	117 updates.html = adblockplusui/updates.html

118 updates.js = adblockplusui/updates.js	118 updates.js = adblockplusui/updates.js

119 skin/updates.css = adblockplusui/skin/updates.css	119 skin/updates.css = adblockplusui/skin/updates.css

120	120

121 [bundles]	121 [bundles]

122 lib/adblockplus.js =	122 lib/adblockplus.js =

123 adblockpluscore/lib/filterListener.js	123 adblockpluscore/lib/filterListener.js

124 adblockpluscore/lib/synchronizer.js	124 adblockpluscore/lib/synchronizer.js

125 lib/requestBlocker.js	125 lib/requestBlocker.js

(...skipping 14 matching lines...) Expand all Loading...
140 qunit/tests/url.js	140 qunit/tests/url.js

141 qunit/tests/cssEscaping.js	141 qunit/tests/cssEscaping.js

142	142

143 [import_locales]	143 [import_locales]

144 adblockplusui/locale//antiadblockInit.json =	144 adblockplusui/locale//antiadblockInit.json =

145 adblockplusui/locale//common.json =	145 adblockplusui/locale//common.json =

146 adblockplusui/locale//desktop-options.json =	146 adblockplusui/locale//desktop-options.json =

147 adblockplusui/locale//firstRun.json =	147 adblockplusui/locale//firstRun.json =

148 adblockplusui/locale//issue-reporter.json =	148 adblockplusui/locale//issue-reporter.json =

149 adblockplusui/locale//updates.json =	149 adblockplusui/locale//updates.json =

OLD	NEW

« lib/csp.js ('K') | « lib/requestBlocker.js ('k') | no next file » | no next file with comments »