Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 29680702: Issue 6008 - Expose updates version via lib/prefs.js (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by Thomas Greiner
Modified:
1 year, 9 months ago
Reviewers:
saroyanm
CC:
kzar
Visibility:
Public.

Description

This change exposes the updates version to the extension so that it can decide whether or not the updates page should be shown. See also https://codereview.adblockplus.org/29664623/ for related changes to adblockpluschrome.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Renamed lib/ui.js to lib/prefs.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M README.md View 1 chunk +2 lines, -0 lines 0 comments Download
A lib/prefs.js View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Thomas Greiner
1 year, 9 months ago (2018-01-26 18:10:50 UTC) #1
saroyanm
https://codereview.adblockplus.org/29680702/diff/29680703/lib/ui.js File lib/ui.js (right): https://codereview.adblockplus.org/29680702/diff/29680703/lib/ui.js#newcode1 lib/ui.js:1: /* All looks fine and I don't want to ...
1 year, 9 months ago (2018-01-30 15:00:41 UTC) #2
Thomas Greiner
https://codereview.adblockplus.org/29680702/diff/29680703/lib/ui.js File lib/ui.js (right): https://codereview.adblockplus.org/29680702/diff/29680703/lib/ui.js#newcode1 lib/ui.js:1: /* On 2018/01/30 15:00:40, saroyanm wrote: > All looks ...
1 year, 9 months ago (2018-01-30 18:20:39 UTC) #3
saroyanm
1 year, 9 months ago (2018-01-31 10:24:27 UTC) #4
LGTM considering that the https://codereview.adblockplus.org/29664623 review
will be updated accordingly.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5