test/compiled/String.cpp - Issue 29680720: Issue 6221 - Add native tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: test/compiled/String.cpp

Issue 29680720: Issue 6221 - Add native tests. (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Patch Set: Created Jan. 26, 2018, 8:49 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1

	2 #include <string>

	3
	sergei 2018/01/26 22:13:36 Could you please remove the empty lines and add th Could you please remove the empty lines and add the license header here? hub 2018/01/27 03:33:37 Done. Show quoted text On 2018/01/26 22:13:36, sergei wrote: > Could you please remove the empty lines and add the license header here? Done.
	4 #include "gtest/gtest.h"

	5

	6 #include "compiled/String.h"

	7

	8 TEST(TestString, DependentString)

	9 {

	10 DependentString s;

	11 EXPECT_TRUE(s.is_invalid());

	12

	13 DependentString s2(s);

	14 EXPECT_TRUE(s2.is_invalid());

	15 }

	16

	17 TEST(TestString, OwnedString)

	18 {

	19 OwnedString s;

	20 EXPECT_TRUE(s.is_invalid());

	21

	22 // Valid string

	23 OwnedString s2(2);

	24 EXPECT_FALSE(s2.is_invalid());

	25

	26 // Ensure we still have an invalid string.

	27 OwnedString s3(s);

	28 EXPECT_TRUE(s3.is_invalid());

	29

	30 // Empty valid string lead to valid string.

	31 OwnedString s4(u""_str);

	32 EXPECT_FALSE(s4.is_invalid());

	33 }

	34

OLD	NEW