Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: test/compiled/RegExp.cpp

Issue 29680720: Issue 6221 - Add native tests. (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Left Patch Set: Changes from review. Created Jan. 27, 2018, 3:33 a.m.
Right Patch Set: Review comments addressed Created Jan. 29, 2018, 4:56 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « meson.build ('k') | test/compiled/String.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #include "gtest/gtest.h" 18 #include "gtest/gtest.h"
19 #include "compiled/String.h" 19 #include "compiled/String.h"
20 20
21 TEST(TestRegexp, RegExp) 21 TEST(TestRegexp, RegExp)
22 { 22 {
23 auto id = GenerateRegExp(u"[0-9]*"_str, false); 23 auto id = GenerateRegExp(u"[0-9]*"_str, false);
24 EXPECT_EQ(id, 0); 24 EXPECT_EQ(id, 0);
25 EXPECT_FALSE(TestRegExp(id, u"abcd"_str)); 25 EXPECT_FALSE(TestRegExp(id, u"abcd"_str));
26 EXPECT_TRUE(TestRegExp(id, u"1234"_str)); 26 EXPECT_TRUE(TestRegExp(id, u"1234"_str));
sergei 2018/01/29 13:38:44 I think, formally we should delete the regular exp
hub 2018/01/29 16:57:46 Done.
27
28 DeleteRegExp(id);
29 // RegExp has been delete: all is false
30 EXPECT_FALSE(TestRegExp(id, u"abcd"_str));
sergei 2018/01/30 13:05:37 I'm not sure that it should work this way, but OK,
31 EXPECT_FALSE(TestRegExp(id, u"1234"_str));
27 } 32 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld