Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: skin/desktop-options.css

Issue 29683678: Issue 5542: Implement tooltips for new options page (Closed)
Left Patch Set: made tooltip a11y friendly/focusable Created Feb. 5, 2018, 11:03 a.m.
Right Patch Set: cleaning up the patch Created Feb. 5, 2018, 12:35 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« desktop-options.js ('K') | « desktop-options.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 .side-controls:not(.wrap) 218 .side-controls:not(.wrap)
219 { 219 {
220 margin: 0.8rem 0rem; 220 margin: 0.8rem 0rem;
221 display: flex; 221 display: flex;
222 justify-content: flex-end; 222 justify-content: flex-end;
223 } 223 }
224 224
225 .side-controls button 225 .side-controls button
226 { 226 {
227 margin: 0rem; 227 margin: 0rem;
228 } 228 -moz-margin-start: 1rem;
229 229 -webkit-margin-start: 1rem;
230 /*
231 Due to Edge adoption as new target browser
232 we cannot use -moz/webkit-margin-start
233 or -moz/webkit-margin-end because
234 these lack Edge support.
235 Yet we need to preserve html direction
236 and potential UI that might swap right to left.
237 */
238 html:not([dir="rtl"]) .side-controls button
239 {
240 margin-left: 1rem;
241 }
242
243 html[dir="rtl"] .side-controls button
244 {
245 margin-right: 1rem;
246 } 230 }
247 231
248 .side-controls.wrap button 232 .side-controls.wrap button
249 { 233 {
250 margin: 0.6rem 0rem; 234 margin: 0.6rem 0rem;
251 } 235 -moz-margin-start: auto;
252 236 -webkit-margin-start: auto;
253 html:not([dir="rtl"]) .side-controls.wrap button
254 {
255 margin-left: auto;
256 }
257
258 html[dir="rtl"] .side-controls.wrap button
259 {
260 margin-right: auto;
261 } 237 }
262 238
263 /* 239 /*
264 icons 240 icons
265 */ 241 */
266 242
267 .icon 243 .icon
268 { 244 {
269 border: 0px; 245 border: 0px;
270 padding: 0px; 246 padding: 0px;
(...skipping 290 matching lines...) Expand 10 before | Expand all | Expand 10 after
561 537
562 #sidebar, 538 #sidebar,
563 #sidebar .fixed, 539 #sidebar .fixed,
564 [role="tablist"] 540 [role="tablist"]
565 { 541 {
566 width: 14.3rem; 542 width: 14.3rem;
567 } 543 }
568 544
569 #sidebar 545 #sidebar
570 { 546 {
571 flex-shrink: 0; 547 flex-shrink: 0;
572 } 548 }
573 549
574 #sidebar .fixed 550 #sidebar .fixed
575 { 551 {
576 top: 1.2rem; 552 top: 1.2rem;
577 bottom: 0rem; 553 bottom: 0rem;
578 height: auto; 554 height: auto;
579 } 555 }
580 556
581 #sidebar header 557 #sidebar header
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
632 padding: 0rem; 608 padding: 0rem;
633 position: relative; 609 position: relative;
634 font-size: 1rem; 610 font-size: 1rem;
635 } 611 }
636 612
637 [role="tablist"] li a 613 [role="tablist"] li a
638 { 614 {
639 display: flex; 615 display: flex;
640 margin-top: -1px; 616 margin-top: -1px;
641 padding: 1rem 0.8rem; 617 padding: 1rem 0.8rem;
642 margin-left: -1px; 618 -moz-margin-end: -1px;
643 margin-right: -1px; 619 -webkit-margin-end: -1px;
620 -moz-margin-start: -1px;
621 -webkit-margin-start: -1px;
644 border-color: #CDCDCD transparent; 622 border-color: #CDCDCD transparent;
645 border-style: solid; 623 border-style: solid;
646 border-width: 1px; 624 border-width: 1px;
647 text-decoration: none; 625 text-decoration: none;
648 color: inherit; 626 color: inherit;
649 cursor: pointer; 627 cursor: pointer;
650 } 628 }
651 629
652 li a[role="tab"][aria-selected] 630 li a[role="tab"][aria-selected]
653 { 631 {
632 -moz-border-start-color: #CDCDCD;
633 -webkit-border-start-color: #CDCDCD;
654 font-weight: 700; 634 font-weight: 700;
655 background-color: #FFF; 635 background-color: #FFF;
656 }
657
658 html:not([dir="rtl"]) li a[role="tab"][aria-selected]
659 {
660 border-left-color: #CDCDCD;
661 }
662
663 html[dir="rtl"] li a[role="tab"][aria-selected]
664 {
665 border-right-color: #CDCDCD;
666 } 636 }
667 637
668 #sidebar footer 638 #sidebar footer
669 { 639 {
670 width: 100%; 640 width: 100%;
671 } 641 }
672 642
673 #sidebar footer p 643 #sidebar footer p
674 { 644 {
675 display: flex; 645 display: flex;
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
758 } 728 }
759 729
760 section.cols 730 section.cols
761 { 731 {
762 display: flex; 732 display: flex;
763 } 733 }
764 734
765 section.cols > *:first-child 735 section.cols > *:first-child
766 { 736 {
767 flex: 1; 737 flex: 1;
768 } 738 -moz-margin-end: 2rem;
769 739 -webkit-margin-end: 2rem;
770 html:not([dir="rtl"]) section.cols > *:first-child
771 {
772 margin-right: 2rem;
773 }
774
775 html[dir="rtl"] section.cols > *:first-child
776 {
777 margin-left: 2rem;
778 } 740 }
779 741
780 section.cols > *:last-child 742 section.cols > *:last-child
781 { 743 {
782 flex: 3; 744 flex: 3;
783 } 745 }
784 746
785 /* 747 /*
786 Acceptable ads 748 Acceptable ads
787 */ 749 */
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
842 html[dir="rtl"] button 804 html[dir="rtl"] button
843 { 805 {
844 left: auto; 806 left: auto;
845 right: 0rem; 807 right: 0rem;
846 } 808 }
847 809
848 #acceptable-ads label 810 #acceptable-ads label
849 { 811 {
850 font-weight: 700; 812 font-weight: 700;
851 font-size: 1rem; 813 font-size: 1rem;
852 } 814 -moz-margin-end: 0.5rem;
853 815 -webkit-margin-end: 0.5rem;
854 html:not([dir="rtl"]) #acceptable-ads label
855 {
856 margin-right: 0.5rem;
857 }
858
859 html[dir="rtl"] #acceptable-ads label
860 {
861 margin-left: 0.5rem;
862 } 816 }
863 817
864 #dnt 818 #dnt
865 { 819 {
866 padding: 0.8rem; 820 padding: 0.8rem;
867 border: 1px solid #077CA6; 821 border: 1px solid #077CA6;
868 } 822 }
869 823
870 .new 824 .new
871 { 825 {
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
1015 .th .col5:nth-of-type(4), 969 .th .col5:nth-of-type(4),
1016 .table .col5:nth-of-type(4) 970 .table .col5:nth-of-type(4)
1017 { 971 {
1018 flex: 1; 972 flex: 1;
1019 } 973 }
1020 974
1021 .th .col5:nth-of-type(5), 975 .th .col5:nth-of-type(5),
1022 .table .col5:nth-of-type(5) 976 .table .col5:nth-of-type(5)
1023 { 977 {
1024 flex: 1; 978 flex: 1;
1025 } 979 -moz-margin-start: 0;
1026 980 -webkit-margin-start: 0;
1027 html:not([dir="rtl"]) .th .col5:nth-of-type(5), 981 -moz-margin-end: 1.8rem;
1028 html:not([dir="rtl"]) .table .col5:nth-of-type(5) 982 -webkit-margin-end: 1.8rem;
1029 {
1030 margin-left: 0;
1031 margin-right: 1.8rem;
1032 }
1033
1034 html[dir="rtl"] .th .col5:nth-of-type(5),
1035 html[dir="rtl"] .table .col5:nth-of-type(5)
1036 {
1037 margin-right: 0;
1038 margin-left: 1.8rem;
1039 } 983 }
1040 984
1041 .table.cols > span 985 .table.cols > span
1042 { 986 {
1043 margin: 0rem; 987 margin: 0rem;
1044 } 988 }
1045 989
1046 .table.cols li 990 .table.cols li
1047 { 991 {
1048 padding: 0.5rem 0rem; 992 padding: 0.5rem 0rem;
1049 } 993 }
1050 994
1051 html:not([dir="rtl"]) .table.cols .state 995 .table.cols .state
1052 { 996 {
1053 margin-left: 1rem; 997 -moz-margin-start: 1rem;
1054 } 998 -webkit-margin-start: 1rem;
1055
1056 html[dir="rtl"] .table.cols .state
1057 {
1058 margin-right: 1rem;
1059 } 999 }
1060 1000
1061 .table.cols .gear 1001 .table.cols .gear
1062 { 1002 {
1063 margin: 0rem 1003 margin: 0rem
1064 } 1004 }
1065 1005
1066 #dialog .table.list li 1006 #dialog .table.list li
1067 { 1007 {
1068 display: block; 1008 display: block;
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
1104 font-weight: 400; 1044 font-weight: 400;
1105 } 1045 }
1106 1046
1107 /* 1047 /*
1108 Tooltips 1048 Tooltips
1109 */ 1049 */
1110 1050
1111 .tooltip 1051 .tooltip
1112 { 1052 {
1113 position: relative; 1053 position: relative;
1114 margin: 0; 1054 margin: 0rem;
1055 -moz-margin-end: 1rem;
1056 -webkit-margin-end: 1rem;
1115 line-height: 1.5rem; 1057 line-height: 1.5rem;
1116 text-decoration: none; 1058 text-decoration: none;
1117 cursor: help; 1059 cursor: help;
1118 /* reset minimal button style */ 1060 /* reset minimal button style */
1119 color: inherit; 1061 color: inherit;
1120 font: inherit; 1062 font: inherit;
1121 text-transform: initial; 1063 text-transform: initial;
1122 text-align: initial; 1064 text-align: initial;
1123 font-weight: initial; 1065 font-weight: initial;
1124 font-size: initial; 1066 font-size: initial;
1125 } 1067 }
1126 1068
1127 html:not([dir="rtl"]) .tooltip
1128 {
1129 margin-right: 1rem;
1130 }
1131
1132 html[dir="rtl"] .tooltip
1133 {
1134 margin-left: 1rem;
1135 }
1136
1137 /* 1069 /*
1138 Used for translatable screen reader only content. 1070 Used for translatable screen reader only content.
1139 e.g.: Use instead of aria-label to avoid complex attribute value translation 1071 e.g.: Use instead of aria-label to avoid complex attribute value translation
1140 */ 1072 */
1141 .sr-only 1073 .sr-only
1142 { 1074 {
1143 position: absolute; 1075 position: absolute;
1144 overflow: hidden; 1076 overflow: hidden;
1145 clip: rect(0, 0, 0, 0); 1077 clip: rect(0, 0, 0, 0);
1146 width: 1px; 1078 width: 1px;
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
1178 1110
1179 #content-whitelist form input 1111 #content-whitelist form input
1180 { 1112 {
1181 flex: 1; 1113 flex: 1;
1182 height: 100%; 1114 height: 100%;
1183 padding: 0.5rem 1rem; 1115 padding: 0.5rem 1rem;
1184 font-size: 1rem; 1116 font-size: 1rem;
1185 border: 2px solid #077CA6; 1117 border: 2px solid #077CA6;
1186 } 1118 }
1187 1119
1188 html:not([dir="rtl"]) #content-whitelist form button 1120 #content-whitelist form button
1189 { 1121 {
1190 margin-left: 0.7rem; 1122 -moz-margin-start: 0.7rem;
1191 } 1123 -webkit-margin-start: 0.7rem;
1192
1193 html[dir="rtl"] #content-whitelist form button
1194 {
1195 margin-right: 0.7rem;
1196 } 1124 }
1197 1125
1198 #whitelisting-table li 1126 #whitelisting-table li
1199 { 1127 {
1200 padding-left: 1.4rem; 1128 padding-left: 1.4rem;
1201 padding-right: 1.4rem; 1129 padding-right: 1.4rem;
1202 border-left: 0rem; 1130 border-left: 0rem;
1203 border-right: 0rem; 1131 border-right: 0rem;
1204 } 1132 }
1205 1133
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
1255 1183
1256 /* 1184 /*
1257 Context menu 1185 Context menu
1258 */ 1186 */
1259 1187
1260 li [role="menubar"] 1188 li [role="menubar"]
1261 { 1189 {
1262 position: relative; 1190 position: relative;
1263 } 1191 }
1264 1192
1265 [role="tooltip"] 1193 [role="tooltip"],
1194 [role="tooltip"]:hover
1266 { 1195 {
1267 right: -0.8rem; 1196 right: -0.8rem;
1268 margin-top: 0.8rem; 1197 margin-top: 0.8rem;
1269 opacity: 1;
1270 padding: 0.2rem 1rem; 1198 padding: 0.2rem 1rem;
1271 position: absolute; 1199 position: absolute;
1272 visibility: visible; 1200 -webkit-transition: opacity 200ms ease-in-out 0ms,
1201 visibility 0ms linear 0ms;
1202 transition: opacity 200ms ease-in-out 0ms,
1203 visibility 0ms linear 0ms;
1204 visibility: hidden;
1205 opacity: 0;
1273 width: 15rem; 1206 width: 15rem;
1274 z-index: 1; 1207 z-index: 1;
1275 }
1276
1277 .tooltip:not(:focus) > [role="tooltip"]
1278 {
1279 -webkit-transition: opacity 200ms ease-in-out 400ms,
1280 visibility 0ms linear 400ms;
1281 transition: opacity 200ms ease-in-out 400ms,
1282 visibility 0ms linear 400ms;
1283 } 1208 }
1284 1209
1285 html[dir="rtl"] [role="tooltip"] 1210 html[dir="rtl"] [role="tooltip"]
1286 { 1211 {
1287 right: auto; 1212 right: auto;
1288 left: -0.8rem; 1213 left: -0.8rem;
1289 } 1214 }
1290 1215
1291 [role="tooltip"], 1216 [role="tooltip"],
1292 .context-menu .content 1217 .context-menu .content
1293 { 1218 {
1294 border: 1px solid #077CA6; 1219 border: 1px solid #077CA6;
1295 border-radius: 3px; 1220 border-radius: 3px;
1296 background-color: #FFFFFF; 1221 background-color: #FFFFFF;
1297 } 1222 }
1298 1223
1299 .tooltip:not(:focus):not(:hover) > [role="tooltip"], 1224 .tooltip:focus > [role="tooltip"],
1300 [role="tooltip"]:hover 1225 .tooltip:hover > [role="tooltip"]
1301 { 1226 {
1302 visibility: hidden; 1227 visibility: visible;
1303 opacity: 0; 1228 opacity: 1;
1304 -webkit-transition-delay: 0ms; 1229 }
1305 transition-delay: 0ms; 1230
1231 .tooltip:hover > [role="tooltip"]
1232 {
1233 -webkit-transition-delay: 400ms;
1234 transition-delay: 400ms;
1306 } 1235 }
1307 1236
1308 .context-menu 1237 .context-menu
1309 { 1238 {
1310 position: absolute; 1239 position: absolute;
1311 right: 2.5rem; 1240 right: 2.5rem;
1312 top: -2rem; 1241 top: -2rem;
1313 z-index: 1; 1242 z-index: 1;
1314 visibility: hidden; 1243 visibility: hidden;
1315 } 1244 }
(...skipping 10 matching lines...) Expand all
1326 position: relative; 1255 position: relative;
1327 cursor: default; 1256 cursor: default;
1328 } 1257 }
1329 1258
1330 li.show-context-menu .context-menu 1259 li.show-context-menu .context-menu
1331 { 1260 {
1332 visibility: visible; 1261 visibility: visible;
1333 } 1262 }
1334 1263
1335 [role="tooltip"]::before, 1264 [role="tooltip"]::before,
1265 [role="tooltip"]::after,
1336 .context-menu::before 1266 .context-menu::before
1337 { 1267 {
1338 content: ""; 1268 content: "";
1339 width: 0rem; 1269 width: 0rem;
1340 height: 0rem; 1270 height: 0rem;
1341 position: absolute; 1271 position: absolute;
1342 } 1272 }
1343 1273
1344 [role="tooltip"]::before 1274 [role="tooltip"]::before
1345 { 1275 {
1346 border-left: 10px solid transparent; 1276 border-left: 10px solid transparent;
1347 border-right: 10px solid transparent; 1277 border-right: 10px solid transparent;
1348 border-bottom: 10px solid #077CA6; 1278 border-bottom: 10px solid #077CA6;
1349 top: -10px; 1279 top: -10px;
1350 right: 15px; 1280 right: 15px;
1351 } 1281 }
1352 1282
1353 html[dir="rtl"] [role="tooltip"]::before 1283 [role="tooltip"]::after
1284 {
1285 border-left: 10px solid transparent;
1286 border-right: 10px solid transparent;
1287 border-bottom: 10px solid #FFFFFF;
1288 top: -9px;
1289 right: 15px;
1290 }
1291
1292 html[dir="rtl"] [role="tooltip"]::before,
1293 html[dir="rtl"] [role="tooltip"]::after
1354 { 1294 {
1355 right: auto; 1295 right: auto;
1356 left: 15px; 1296 left: 15px;
1357 } 1297 }
1358 1298
1359 .context-menu::before 1299 .context-menu::before
1360 { 1300 {
1361 border-left: 10px solid #077CA6; 1301 border-left: 10px solid #077CA6;
1362 border-top: 10px solid transparent; 1302 border-top: 10px solid transparent;
1363 border-bottom: 10px solid transparent; 1303 border-bottom: 10px solid transparent;
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
1421 1361
1422 #social ul 1362 #social ul
1423 { 1363 {
1424 list-style: none; 1364 list-style: none;
1425 padding: 0px; 1365 padding: 0px;
1426 } 1366 }
1427 1367
1428 #social ul li 1368 #social ul li
1429 { 1369 {
1430 display: inline-block; 1370 display: inline-block;
1431 } 1371 -moz-margin-end: 1rem;
1432 1372 -webkit-margin-end: 1rem;
1433 html:not([dir="rtl"]) #social ul li
1434 {
1435 margin-right: 1rem;
1436 }
1437
1438 html[dir="rtl"] #social ul li
1439 {
1440 margin-left: 1rem;
1441 } 1373 }
1442 1374
1443 #social ul li a 1375 #social ul li a
1444 { 1376 {
1445 display: block; 1377 display: block;
1446 text-align: center; 1378 text-align: center;
1447 text-decoration: none; 1379 text-decoration: none;
1448 } 1380 }
1449 1381
1450 /* 1382 /*
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
1601 font-size: 1rem; 1533 font-size: 1rem;
1602 color: #077CA6; 1534 color: #077CA6;
1603 background-color: #E1F2FA; 1535 background-color: #E1F2FA;
1604 } 1536 }
1605 1537
1606 #notification strong 1538 #notification strong
1607 { 1539 {
1608 flex: 1; 1540 flex: 1;
1609 text-align: center; 1541 text-align: center;
1610 } 1542 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld