Unified Diff: desktop-options.html
Issue 29683678:
Issue 5542: Implement tooltips for new options page (Closed)
Patch Set: made tooltip a11y friendly/focusable
Created Feb. 5, 2018, 11:03 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
desktop-options.js » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: desktop-options.html |
| =================================================================== |
| --- a/desktop-options.html |
| +++ b/desktop-options.html |
| @@ -87,7 +87,7 @@ |
| <template> |
| <button data-action="toggle-remove-subscription" role="checkbox" class="control icon"></button> |
| <span data-display="title"></span> |
| - <span data-tooltip="options_protection_%value%_tooltip"></span> |
| + <button data-tooltip="options_protection_%value%_tooltip"></button> |
| </template> |
| </ul> |
| </section> |
| @@ -205,17 +205,17 @@ |
| <li data-pref="shouldShowBlockElementMenu"> |
| <button class="icon" role="checkbox" data-action="toggle-pref"></button> |
| <span class="i18n_options_customize_blockElement" data-display="title"></span> |
| - <span data-tooltip="options_customize_blockElement_tooltip"></span> |
| + <button data-tooltip="options_customize_blockElement_tooltip"></button> |
| </li> |
| <li data-pref="show_devtools_panel"> |
| <button class="icon" role="checkbox" data-action="toggle-pref"></button> |
| <span class="i18n_options_customize_showDevToolsPanel" data-display="title"></span> |
| - <span data-tooltip="options_customize_showDevToolsPanel_tooltip"></span> |
| + <button data-tooltip="options_customize_showDevToolsPanel_tooltip"></button> |
| </li> |
| <li data-pref="notifications_ignoredcategories"> |
| <button class="icon" role="checkbox" data-action="toggle-pref"></button> |
| <span class="i18n_options_customize_showNotifications" data-display="title"></span> |
| - <span data-tooltip="options_customize_showNotifications_tooltip"></span> |
| + <button data-tooltip="options_customize_showNotifications_tooltip"></button> |
| </li> |
| </ul> |
| </section> |
« no previous file with comments
|
« no previous file
|
desktop-options.js » ('j')
|
no next file with comments »
