Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: build/config/android/version.gni
Issue
29684695
:
Issue 6287 - Create codename Orca v.0 to launch internally to the team (Closed)
Patch Set: Added link to issue and adjusted versionName
Created Feb. 1, 2018, 8:51 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Added basic versioning
Patch Set 3: Added link to issue and adjusted versionName
Patch Set 4: Fixed comments
Right:
Patch Set 1: None
Patch Set 2: Added basic versioning
Patch Set 3: Added link to issue and adjusted versionName
Patch Set 4: Fixed comments
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
build/config/android/version.gni
chrome/android/BUILD.gn
chrome/android/chrome_public_apk_tmpl.gni
chrome/android/java/res_orca/drawable-hdpi/fre_product_logo.png
chrome/android/java/res_orca/drawable-hdpi/product_logo_name.png
chrome/android/java/res_orca/drawable-mdpi/fre_product_logo.png
chrome/android/java/res_orca/drawable-mdpi/product_logo_name.png
chrome/android/java/res_orca/drawable-xhdpi/fre_product_logo.png
chrome/android/java/res_orca/drawable-xhdpi/product_logo_name.png
chrome/android/java/res_orca/drawable-xxhdpi/fre_product_logo.png
chrome/android/java/res_orca/drawable-xxhdpi/product_logo_name.png
chrome/android/java/res_orca/drawable-xxxhdpi/fre_product_logo.png
chrome/android/java/res_orca/drawable-xxxhdpi/product_logo_name.png
chrome/android/java/res_orca/mipmap-hdpi/app_icon.png
chrome/android/java/res_orca/mipmap-hdpi/app_shortcut_icon.png
chrome/android/java/res_orca/mipmap-hdpi/app_single_page_icon.png
chrome/android/java/res_orca/mipmap-mdpi/app_icon.png
chrome/android/java/res_orca/mipmap-mdpi/app_shortcut_icon.png
chrome/android/java/res_orca/mipmap-mdpi/app_single_page_icon.png
chrome/android/java/res_orca/mipmap-xhdpi/app_icon.png
chrome/android/java/res_orca/mipmap-xhdpi/app_shortcut_icon.png
chrome/android/java/res_orca/mipmap-xhdpi/app_single_page_icon.png
chrome/android/java/res_orca/mipmap-xxhdpi/app_icon.png
chrome/android/java/res_orca/mipmap-xxhdpi/app_shortcut_icon.png
chrome/android/java/res_orca/mipmap-xxhdpi/app_single_page_icon.png
chrome/android/java/res_orca/mipmap-xxxhdpi/app_icon.png
chrome/android/java/res_orca/mipmap-xxxhdpi/app_shortcut_icon.png
chrome/android/java/res_orca/mipmap-xxxhdpi/app_single_page_icon.png
chrome/android/java/res_orca/values/channel_constants.xml
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
chrome/android/BUILD.gn »
('j') |
chrome/android/BUILD.gn »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
# TODO: Add copyright text
2
# For now we keep the versioning of the app in here
3
4
# versionName
5
android_version_name = "0.1.0"
6
7
# versionCode
8
android_version_code = "1"
OLD
NEW
« no previous file with comments
|
« no previous file
|
chrome/android/BUILD.gn »
('j') |
chrome/android/BUILD.gn »
('J')
Edit Message
Issue 29684695: Issue 6287 - Create codename Orca v.0 to launch internally to the team (Closed)
Created Jan. 30, 2018, 4:52 p.m. by jens
Modified Feb. 21, 2018, 9:26 a.m.
Reviewers: diegocarloslima, anton
Base URL:
Comments: 10
This is Rietveld