build/config/android/version.gni - Issue 29684695: Issue 6287 - Create codename Orca v.0 to launch internally to the team

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: build/config/android/version.gni

Issue 29684695: Issue 6287 - Create codename Orca v.0 to launch internally to the team (Closed)

Left Patch Set: Added basic versioning Created Jan. 31, 2018, 4:54 p.m.

Right Patch Set: Fixed comments Created Feb. 2, 2018, 12:50 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 # TODO: Add copyright text	1 # TODO: Add copyright text

2 # For now we keep the versioning of the app in here	2 # For now we keep the versioning of the app in here

3	3

4 # versionName	4 # versionName

5 android_version_name = "Orca Alpha 1"	5 android_version_name = "0.1.0"
anton 2018/02/01 05:34:44 i think "Orca" relates to app name/title rather th i think "Orca" relates to app name/title rather than to app version name. I'd remove "Orca". Also according to our charters ticket http://hub.eyeo.com/issues/7589 it's target version "0.1.0". Let use it. So i'd use `android_version_name = "0.1.0"` jens 2018/02/01 08:54:51 Acknowledged. Show quoted text On 2018/02/01 05:34:44, anton wrote: > i think "Orca" relates to app name/title rather than to app version name. I'd > remove "Orca". Also according to our charters ticket > http://hub.eyeo.com/issues/7589 it's target version "0.1.0". Let use it. So i'd > use `android_version_name = "0.1.0"` Acknowledged.
6	6

7 # versionCode	7 # versionCode

8 android_version_code = "1"	8 android_version_code = "1"

LEFT	RIGHT