Issue 6287 - Create codename Orca v.0 to launch internally to the team

chrome/android/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//base/android/jni_generator/jni_exception_list.gni")
 import("//build/config/android/config.gni")
 import("//build/config/android/rules.gni")
 import("//build/util/process_version.gni")
 import("//chrome/android/chrome_public_apk_tmpl.gni")
 import("//chrome/android/monochrome_android_manifest_jinja_variables.gni")
@@ skipping 957 matching lines @@
       ":chrome_public_non_pak_assets",
       ":chrome_public_pak_assets",
       "//base:base_java",
     ]
   }
 }
 
 chrome_public_apk_tmpl_shared("chrome_public_apk") {
   android_manifest = chrome_public_android_manifest
   android_manifest_dep = ":chrome_public_android_manifest"
-  # Change res directory for rebranding. See https://issues.adblockplus.org/ticket/6287

[diegocarloslima, 2018/01/31 17:48:44]

The comment here and the following ones should be something like: 'Change apk
name', because we're not changing any directory here

[jens, 2018/02/01 08:54:51]

Acknowledged.

+  # Change APK name for rebranding. See https://issues.adblockplus.org/ticket/6287
   apk_name = "OrcaPublic"
   shared_libraries = [ ":chrome" ]
   shared_libraries += [ "//third_party/libadblockplus_android:aar_java_native" ]
 }
 
 chrome_public_apk_tmpl_shared("chrome_modern_public_apk") {
   android_manifest = chrome_modern_public_android_manifest
   android_manifest_dep = ":chrome_modern_public_android_manifest"
-  # Change res directory for rebranding. See https://issues.adblockplus.org/ticket/6287
+  # Change APK name for rebranding. See https://issues.adblockplus.org/ticket/6287
   apk_name = "OrcaModernPublic"
   shared_libraries = [ ":chrome" ]
   shared_libraries += [ "//third_party/libadblockplus_android:aar_java_native" ]
 
   if (!is_java_debug) {
     png_to_webp = true
   }
 
   # Always enable load_library_from_apk.
   load_library_from_apk = chromium_linker_supported
@@ skipping 106 matching lines @@
   }
 
   # The test APK contains code from both the APK under test and the
   # test APK when proguard is enabled. That causes this APK to exceed
   # the dex limit.
   enable_multidex = proguard_enabled
 }
 
 if (enable_vr) {
   instrumentation_test_apk("chrome_public_test_vr_apk") {
-    # Change res directory for rebranding. See https://issues.adblockplus.org/ticket/6287
+    # Change APK name for rebranding. See https://issues.adblockplus.org/ticket/6287
     apk_name = "OrcaPublicTestVr"
     apk_under_test = ":chrome_public_apk"
     android_manifest = chrome_public_test_vr_apk_manifest
     android_manifest_dep = ":chrome_public_test_vr_apk_manifest"
 
     deps = [
       ":chrome_test_vr_java",
     ]
     additional_apks = [ "//net/android:net_test_support_apk" ]
     proguard_enabled = !is_java_debug
@@ skipping 58 matching lines @@
     "//ui/android:ui_java",
   ]
   proguard_enabled = !is_java_debug
   if (proguard_enabled && !enable_proguard_obfuscation &&
       enable_proguard_obfuscation_for_tests) {
     proguard_configs = [ "//base/android/proguard/enable_obfuscation.flags" ]
     proguard_config_exclusions =
         [ "//base/android/proguard/disable_chromium_obfuscation.flags" ]
   }
 }