Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/android/chrome_public_apk_tmpl.gni

Issue 29684695: Issue 6287 - Create codename Orca v.0 to launch internally to the team (Closed)
Patch Set: Added basic versioning Created Jan. 31, 2018, 4:54 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/chrome_public_apk_tmpl.gni
diff --git a/chrome/android/chrome_public_apk_tmpl.gni b/chrome/android/chrome_public_apk_tmpl.gni
index e2905197170e1e7fb33248924ac5c2285fb40c03..837204185d98708d7b2b0a3ccddde2a9304faec4 100644
--- a/chrome/android/chrome_public_apk_tmpl.gni
+++ b/chrome/android/chrome_public_apk_tmpl.gni
@@ -4,6 +4,7 @@
import("//base/android/linker/config.gni")
import("//build/config/android/rules.gni")
+import("//build/config/android/version.gni")
import("//build/config/locales.gni")
import("//chrome/common/features.gni")
import("//third_party/leakcanary/config.gni")
@@ -32,6 +33,12 @@ declare_args() {
# Enable multidex in release builds.
multidex_in_release = false
+
+ # Set versionName for AndroidManifest.xml
diegocarloslima 2018/01/31 17:48:45 Although we can find out when something was added
jens 2018/02/01 08:54:52 Acknowledged.
+ version_name = android_version_name
+
+ # Set versionCode for AndroidManifest.xml
+ version_code = android_version_code
}
default_chrome_public_jinja_variables = [

Powered by Google App Engine
This is Rietveld