Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29690843: Issue 6359 - use C++14 instead of C++1z (Closed)

Created:
Feb. 6, 2018, 10:18 a.m. by sergei
Modified:
Feb. 7, 2018, 2:46 p.m.
Reviewers:
hub
Base URL:
github.com:adblockplus/adblockpluscore
Visibility:
Public.

Patch Set 1 #

Total comments: 3

Patch Set 2 : support more compilers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M compiled/Map.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M compiled/bindings/generator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M meson.build View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
sergei
https://codereview.adblockplus.org/29690843/diff/29690844/compiled/bindings/generator.cpp File compiled/bindings/generator.cpp (right): https://codereview.adblockplus.org/29690843/diff/29690844/compiled/bindings/generator.cpp#newcode494 compiled/bindings/generator.cpp:494: ABP_NS_END I have no idea what changed here
Feb. 6, 2018, 10:19 a.m. (2018-02-06 10:19:58 UTC) #1
hub
LGTM https://codereview.adblockplus.org/29690843/diff/29690844/compiled/bindings/generator.cpp File compiled/bindings/generator.cpp (right): https://codereview.adblockplus.org/29690843/diff/29690844/compiled/bindings/generator.cpp#newcode494 compiled/bindings/generator.cpp:494: ABP_NS_END On 2018/02/06 10:19:58, sergei wrote: > I ...
Feb. 6, 2018, 3:03 p.m. (2018-02-06 15:03:38 UTC) #2
sergei
Feb. 7, 2018, 2:46 p.m. (2018-02-07 14:46:50 UTC) #3
Message was sent while issue was closed.
https://codereview.adblockplus.org/29690843/diff/29690844/compiled/bindings/g...
File compiled/bindings/generator.cpp (right):

https://codereview.adblockplus.org/29690843/diff/29690844/compiled/bindings/g...
compiled/bindings/generator.cpp:494: ABP_NS_END
On 2018/02/06 15:03:38, hub wrote:
> On 2018/02/06 10:19:58, sergei wrote:
> > I have no idea what changed here
> 
> end of line added.

yep strangely vim is not showing a new line after that line, though.
Although it's not in accordance with our policy I didn't include that change of
line ending into the commit since it's unrelated.

Powered by Google App Engine
This is Rietveld