 Issue 29690843:
  Issue 6359 - use C++14 instead of C++1z  (Closed) 
  Base URL: github.com:adblockplus/adblockpluscore
    
  
    Issue 29690843:
  Issue 6359 - use C++14 instead of C++1z  (Closed) 
  Base URL: github.com:adblockplus/adblockpluscore
| Left: | ||
| Right: | 
| OLD | NEW | 
|---|---|
| 1 /* | 1 /* | 
| 2 * This file is part of Adblock Plus <https://adblockplus.org/>, | 2 * This file is part of Adblock Plus <https://adblockplus.org/>, | 
| 3 * Copyright (C) 2006-present eyeo GmbH | 3 * Copyright (C) 2006-present eyeo GmbH | 
| 4 * | 4 * | 
| 5 * Adblock Plus is free software: you can redistribute it and/or modify | 5 * Adblock Plus is free software: you can redistribute it and/or modify | 
| 6 * it under the terms of the GNU General Public License version 3 as | 6 * it under the terms of the GNU General Public License version 3 as | 
| 7 * published by the Free Software Foundation. | 7 * published by the Free Software Foundation. | 
| 8 * | 8 * | 
| 9 * Adblock Plus is distributed in the hope that it will be useful, | 9 * Adblock Plus is distributed in the hope that it will be useful, | 
| 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of | 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of | 
| (...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 108 signature += 'd'; | 108 signature += 'd'; | 
| 109 break; | 109 break; | 
| 110 default: | 110 default: | 
| 111 throw std::runtime_error("Unexpected function argument type"); | 111 throw std::runtime_error("Unexpected function argument type"); | 
| 112 } | 112 } | 
| 113 args.push_back(type); | 113 args.push_back(type); | 
| 114 } | 114 } | 
| 115 | 115 | 
| 116 int nameLength = GetFunctionName(nullptr, function, signature.c_str()); | 116 int nameLength = GetFunctionName(nullptr, function, signature.c_str()); | 
| 117 name.resize(nameLength); | 117 name.resize(nameLength); | 
| 118 GetFunctionName(name.data(), function, signature.c_str()); | 118 GetFunctionName(&name[0], function, signature.c_str()); | 
| 119 } | 119 } | 
| 120 | 120 | 
| 121 bool FunctionInfo::empty() const | 121 bool FunctionInfo::empty() const | 
| 122 { | 122 { | 
| 123 return name.empty(); | 123 return name.empty(); | 
| 124 } | 124 } | 
| 125 | 125 | 
| 126 ClassInfo* find_class(TYPEID classID) | 126 ClassInfo* find_class(TYPEID classID) | 
| 127 { | 127 { | 
| 128 for (auto& classInfo : classes) | 128 for (auto& classInfo : classes) | 
| (...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 484 void printBindings() | 484 void printBindings() | 
| 485 { | 485 { | 
| 486 bindings_internal::printHelpers(); | 486 bindings_internal::printHelpers(); | 
| 487 | 487 | 
| 488 for (const auto& cls : classes) | 488 for (const auto& cls : classes) | 
| 489 bindings_internal::printClass(cls); | 489 bindings_internal::printClass(cls); | 
| 490 for (const auto& cls : classes) | 490 for (const auto& cls : classes) | 
| 491 bindings_internal::printClassMapping(cls); | 491 bindings_internal::printClassMapping(cls); | 
| 492 } | 492 } | 
| 493 | 493 | 
| 494 ABP_NS_END | 494 ABP_NS_END | 
| 
sergei
2018/02/06 10:19:58
I have no idea what changed here
 
hub
2018/02/06 15:03:38
end of line added.
 
sergei
2018/02/07 14:46:50
yep strangely vim is not showing a new line after
 | |
| OLD | NEW |