Delta Between Two Patch Sets: includes/abb-notification.tmpl
Issue 29690912:
Fixes #9 - Update cross-promotional section (Closed)
Base URL: https://hg.adblockplus.org/web.adblockplus.org
Left Patch Set: Addressed comments #2
Created Feb. 20, 2018, 11:16 a.m.
Right Patch Set: Change background image to solid colour
Created Feb. 28, 2018, 8:40 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
includes/index.tmpl » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 <section id="abb-notification" class="section"> | 1 <section id="abb-notification" class="section bg-secondary"> |
|
juliandoucette
2018/02/28 19:48:21
NIT: This isn't really a "notification" anymore IM
ire
2018/03/01 09:11:10
You already brought this up here - https://coderev
juliandoucette
2018/03/01 09:53:33
Yes, thank you. I'll respond there.
| |
| 2 <div class="container phablet-width content text-center"> | 2 <div class="container phablet-width content text-center"> |
| 3 <h2 class="h1">{{ get_string("abb_notification", "abb-notification") }}</h2> | 3 <h2 class="h1">{{ get_string("abb_notification", "abb-notification") }}</h2> |
| 4 | 4 |
| 5 <figure> | 5 <figure> |
| 6 <img src="/img/abb-logo.png" alt="{{ get_string("abb_logo_alt", "abb-notif ication") }}" id="abb-logo"> | 6 <img src="/img/abb-logo.png" alt="{{ get_string("abb_logo_alt", "abb-notif ication") }}" id="abb-logo"> |
| 7 <figcaption> | 7 <figcaption> |
| 8 <h3> | 8 <h3>{{ get_string("abb_notification_link", "abb-notification") }}</h3> |
| 9 <a href="https://eyeo.to/adblockbrowser/abp-website"> | |
| 10 {{ get_string("abb_notification_link", "abb-notification") }} | |
| 11 </a> | |
| 12 </h3> | |
| 13 <p>{{ get_string("abb_notification_description", "abb-notification") }}< /p> | 9 <p>{{ get_string("abb_notification_description", "abb-notification") }}< /p> |
| 14 </figcaption> | 10 </figcaption> |
| 15 </figure> | 11 </figure> |
| 16 | 12 |
| 17 <div id="abb-app-store-badges" class="row"> | 13 <div id="abb-app-store-badges" class="row"> |
| 18 <a href="https://eyeo.to/adblockbrowser/ios/abp-website" title="{{ get_str ing("abb_ios_link_title", "abb-notification") }}" class="column one-half"> | 14 <a href="https://eyeo.to/adblockbrowser/ios/abp-website" title="{{ get_str ing("abb_ios_link_title", "abb-notification") }}" class="column one-half"> |
| 19 <img src="/img/apple-app-store-badge.png" srcset="/img/apple-app-store-b adge.svg 2x" alt="{{ get_string("abb_ios_badge_alt", "abb-notification") }}"> | 15 <img src="/img/apple-app-store-badge.png" srcset="/img/apple-app-store-b adge.svg 2x" alt="{{ get_string("abb_ios_badge_alt", "abb-notification") }}"> |
| 20 </a> | 16 </a> |
| 21 <a href="https://eyeo.to/adblockbrowser/android/abp-website" title="{{ get _string("abb_android_link_title", "abb-notification") }}" class="column one-half "> | 17 <a href="https://eyeo.to/adblockbrowser/android/abp-website" title="{{ get _string("abb_android_link_title", "abb-notification") }}" class="column one-half "> |
| 22 <img src="/img/google-play-badge.png" srcset="/img/google-play-badge.svg 2x" alt="{{ get_string("abb_android_badge_alt", "abb-notification") }}"> | 18 <img src="/img/google-play-badge.png" srcset="/img/google-play-badge.svg 2x" alt="{{ get_string("abb_android_badge_alt", "abb-notification") }}"> |
| 23 </a> | 19 </a> |
| 24 </div> | 20 </div> |
| 25 </div> | 21 </div> |
| 26 </section> | 22 </section> |
| LEFT | RIGHT |
« no previous file
|
includes/index.tmpl » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
