Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: README.md

Issue 29691573: Noissue - Improve dependency management documentation (Closed)
Patch Set: Created Feb. 7, 2018, 11:44 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Adblock Plus for Chrome, Opera, Microsoft Edge and Firefox 1 Adblock Plus for Chrome, Opera, Microsoft Edge and Firefox
2 ========================================================== 2 ==========================================================
3 3
4 This repository contains the platform-specific Adblock Plus source code for 4 This repository contains the platform-specific Adblock Plus source code for
5 Chrome, Opera, Microsoft Edge and Firefox. It can be used to build 5 Chrome, Opera, Microsoft Edge and Firefox. It can be used to build
6 Adblock Plus for these platforms, generic Adblock Plus code will be extracted 6 Adblock Plus for these platforms, generic Adblock Plus code will be extracted
7 from other repositories automatically (see _dependencies_ file). 7 from other repositories automatically (see _dependencies_ file).
8 8
9 Note that the Firefox extension built from this repository is the new 9 Note that the Firefox extension built from this repository is the new
10 [WebExtension](https://developer.mozilla.org/en-US/Add-ons/WebExtensions). 10 [WebExtension](https://developer.mozilla.org/en-US/Add-ons/WebExtensions).
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 under _about:debugging_ in Firefox or in _Extensions_ menu in Microsoft Edge, 60 under _about:debugging_ in Firefox or in _Extensions_ menu in Microsoft Edge,
61 after enabling extension development features in _about:flags_. 61 after enabling extension development features in _about:flags_.
62 After making changes to the source code re-run the command to update the 62 After making changes to the source code re-run the command to update the
63 development environment. In Chrome and Firefox the extension should reload 63 development environment. In Chrome and Firefox the extension should reload
64 automatically after a few seconds. 64 automatically after a few seconds.
65 65
66 Builds for Microsoft Edge do not automatically detect changes, so after 66 Builds for Microsoft Edge do not automatically detect changes, so after
67 rebuilding the extension you should manually force reloading it in Edge by 67 rebuilding the extension you should manually force reloading it in Edge by
68 hitting the _Reload Extension_ button. 68 hitting the _Reload Extension_ button.
69 69
70 #### Skip dependencies check
kzar 2018/02/12 14:06:53 Ditch the header IMO.
a.giammarchi 2018/02/12 15:02:23 Done.
71
72 If you are modifying `adblockpluscore` or `adblockplusui` and you would like
kzar 2018/02/12 14:06:53 How about this? The build script calls the ensure
a.giammarchi 2018/02/12 15:02:23 Done.
73 to build the dev extension, you can specify `SKIP_DEPENDENCY_UPDATES=true`
74 as environment variable so that build tools will not ensure the release commit.
75
76 SKIP_DEPENDENCY_UPDATES=true ./build.py devenv -t chrome
77
70 Running the unit tests 78 Running the unit tests
71 ---------------------- 79 ----------------------
72 80
73 To verify your changes you can use the unit test suite located in the _qunit_ 81 To verify your changes you can use the unit test suite located in the _qunit_
74 directory of the repository. In order to run the unit tests go to the 82 directory of the repository. In order to run the unit tests go to the
75 extension's Options page, open the JavaScript Console and type in: 83 extension's Options page, open the JavaScript Console and type in:
76 84
77 location.href = "qunit/index.html"; 85 location.href = "qunit/index.html";
78 86
79 The unit tests will run automatically once the page loads. 87 The unit tests will run automatically once the page loads.
80 88
81 Linting 89 Linting
82 ------- 90 -------
83 91
84 You can lint the code using [ESLint](http://eslint.org). 92 You can lint the code using [ESLint](http://eslint.org).
85 93
86 eslint *.js lib/ qunit/ ext/ chrome/ 94 eslint *.js lib/ qunit/ ext/ chrome/
87 95
88 You will need to set up ESLint and our configuration first, see 96 You will need to set up ESLint and our configuration first, see
89 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo) 97 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo)
90 for more information. 98 for more information.
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld