Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18)

Issue 29691627: Issue 242 - Do not disable user style sheets on unrelated errors (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by Manish Jethani
Modified:
5 months, 2 weeks ago
Reviewers:
kzar, Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Catch all errors but mark userStyleSheetsSupported=false only for cssOrigin error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M lib/cssInjection.js View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9
Manish Jethani
6 months, 1 week ago (2018-02-07 15:01:03 UTC) #1
Sebastian Noack
Can you elaborate why this check is necessary?
6 months, 1 week ago (2018-02-07 15:05:02 UTC) #2
Manish Jethani
Patch Set 1 I noticed this on one website: a frame gets removed from the ...
6 months, 1 week ago (2018-02-07 15:05:39 UTC) #3
Manish Jethani
On 2018/02/07 15:05:39, Manish Jethani wrote: > Patch Set 1 > > I noticed this ...
6 months, 1 week ago (2018-02-07 15:07:05 UTC) #4
Sebastian Noack
On 2018/02/07 15:07:05, Manish Jethani wrote: > On 2018/02/07 15:05:39, Manish Jethani wrote: > > ...
6 months, 1 week ago (2018-02-07 15:15:40 UTC) #5
Manish Jethani
On 2018/02/07 15:15:40, Sebastian Noack wrote: > On 2018/02/07 15:07:05, Manish Jethani wrote: > > ...
6 months, 1 week ago (2018-02-07 15:21:28 UTC) #6
Manish Jethani
On 2018/02/07 15:21:28, Manish Jethani wrote: > On 2018/02/07 15:15:40, Sebastian Noack wrote: > > ...
5 months, 3 weeks ago (2018-02-20 11:18:53 UTC) #7
Manish Jethani
Patch Set 2: Catch all errors but mark userStyleSheetsSupported=false only for cssOrigin error
5 months, 3 weeks ago (2018-02-21 15:19:56 UTC) #8
kzar
5 months, 2 weeks ago (2018-02-26 15:25:03 UTC) #9
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5