Issue 29691643: Issue 6367 - Update "compact" bookmark to use libadblockplus "compact-fix" bookmark

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29691643: Issue 6367 - Update "compact" bookmark to use libadblockplus "compact-fix" bookmark (Closed)

Created:
Feb. 7, 2018, 4:48 p.m. by anton

Modified:
Feb. 8, 2018, 4:55 a.m.

Reviewers:
sergei, diegocarloslima, jens

CC:
vicky

Visibility:
Public.

Description

Issue 6367 - Update "compact" bookmark to use libadblockplus "update-fix" bookmark Changes to be done in "libadblockplus-binaries" repo. Failed to push code review: hg status M android_armeabi-v7a/libadblockplus.a M android_armeabi-v7a/libv8_base.a M android_armeabi-v7a/libv8_snapshot.a M android_x86/libadblockplus.a M android_x86/libv8_base.a M android_x86/libv8_snapshot.a ./upload ... Not uploading the patch for android_armeabi-v7a/libadblockplus.a because the file is too large. Not uploading the patch for android_armeabi-v7a/libv8_base.a because the file is too large. Not uploading the patch for android_x86/libadblockplus.a because the file is too large. Not uploading the patch for android_x86/libv8_base.a because the file is too large. Uploaded patch for android_armeabi-v7a/libv8_snapshot.a Uploaded patch for android_x86/libv8_snapshot.a Uploading base file for android_armeabi-v7a/libv8_snapshot.a Uploading current file for android_armeabi-v7a/libv8_snapshot.a Uploading base file for android_x86/libv8_snapshot.a Uploading current file for android_x86/libv8_snapshot.a

Patch Set 1 #

Created: Feb. 7, 2018, 4:48 p.m.

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -0 lines)			Patch
	M	android_armeabi-v7a/libv8_snapshot.a	View		Binary file		0 comments	Download
	M	android_x86/libv8_snapshot.a	View		Binary file		0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

diegocarloslima

On 2018/02/07 16:50:28, anton wrote: since this is just a change in binaries, there isn't ...

Feb. 7, 2018, 10:57 p.m. (2018-02-07 22:57:49 UTC) #2

anton

Feb. 8, 2018, 4:39 a.m. (2018-02-08 04:39:02 UTC) #3

On 2018/02/07 22:57:49, diegocarloslima wrote:
> On 2018/02/07 16:50:28, anton wrote:
> 
> since this is just a change in binaries, there isn't much to review. So LGTM,
> even if there are missing files

right

Expand All Messages | Collapse All Messages