Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29691645: Issue 6367 - Update "compact" bookmark to use libadblockplus "compact-fix" bookmark (Closed)

Created:
Feb. 7, 2018, 7:02 p.m. by anton
Modified:
Feb. 8, 2018, 5:50 a.m.
CC:
vicky
Visibility:
Public.

Description

Issue 6367 - Update "compact" bookmark to use libadblockplus "compact-fix" bookmark Changes to be done in "libadblockplus-android" repo. Related to "compact" branch only. #Depends on https://codereview.adblockplus.org/29691643/

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M dependencies View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 4
anton
Feb. 7, 2018, 7:13 p.m. (2018-02-07 19:13:18 UTC) #1
sergei
https://codereview.adblockplus.org/29691645/diff/29691646/dependencies File dependencies (right): https://codereview.adblockplus.org/29691645/diff/29691646/dependencies#newcode4 dependencies:4: libadblockplus-android/jni/libadblockplus-binaries = libadblockplus-binaries hg:e7880657c85b git:4b72988d31286efcff7e0028d6dd35e2fc17f743 JIC, git commit is ...
Feb. 7, 2018, 8:02 p.m. (2018-02-07 20:02:05 UTC) #2
anton
https://codereview.adblockplus.org/29691645/diff/29691646/dependencies File dependencies (right): https://codereview.adblockplus.org/29691645/diff/29691646/dependencies#newcode4 dependencies:4: libadblockplus-android/jni/libadblockplus-binaries = libadblockplus-binaries hg:e7880657c85b git:4b72988d31286efcff7e0028d6dd35e2fc17f743 On 2018/02/07 20:02:04, sergei ...
Feb. 7, 2018, 8:03 p.m. (2018-02-07 20:03:28 UTC) #3
diegocarloslima
Feb. 7, 2018, 10:59 p.m. (2018-02-07 22:59:49 UTC) #4
On 2018/02/07 20:03:28, anton wrote:
> https://codereview.adblockplus.org/29691645/diff/29691646/dependencies
> File dependencies (right):
> 
>
https://codereview.adblockplus.org/29691645/diff/29691646/dependencies#newcode4
> dependencies:4: libadblockplus-android/jni/libadblockplus-binaries =
> libadblockplus-binaries hg:e7880657c85b
> git:4b72988d31286efcff7e0028d6dd35e2fc17f743
> On 2018/02/07 20:02:04, sergei wrote:
> > JIC, git commit is missing so far.
> 
> https://github.com/adblockplus/libadblockplus-binaries/tree/compact-fix

LGTM

Powered by Google App Engine
This is Rietveld