Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(373)

Issue 29692555: Issue #5613 - Removal of social media: Share this number

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 3 days ago by a.giammarchi
Modified:
2 days, 3 hours ago
CC:
Sebastian Noack
Visibility:
Public.

Description

Issue #5613 - Removal of social media: Share this number

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M _locales/en_US/messages.json View 1 1 chunk +0 lines, -4 lines 0 comments Download
M skin/popup.png View 1 Binary file 0 comments Download

Messages

Total messages: 9
a.giammarchi
As mentioned further down the #5613 ticket, we don't want to show social media buttons ...
1 week, 3 days ago (2018-02-08 12:27:04 UTC) #1
saroyanm
https://codereview.adblockplus.org/29692555/diff/29692556/popup.html File popup.html (left): https://codereview.adblockplus.org/29692555/diff/29692556/popup.html#oldcode86 popup.html:86: <span class="i18n_stats_share_title"></span> We still have this String in the ...
4 days, 4 hours ago (2018-02-14 17:19:47 UTC) #2
a.giammarchi
one answer + one question (extra clarification) https://codereview.adblockplus.org/29692555/diff/29692556/popup.html File popup.html (left): https://codereview.adblockplus.org/29692555/diff/29692556/popup.html#oldcode86 popup.html:86: <span class="i18n_stats_share_title"></span> ...
3 days, 12 hours ago (2018-02-15 09:43:10 UTC) #3
saroyanm
https://codereview.adblockplus.org/29692555/diff/29692556/popup.html File popup.html (left): https://codereview.adblockplus.org/29692555/diff/29692556/popup.html#oldcode86 popup.html:86: <span class="i18n_stats_share_title"></span> On 2018/02/15 09:43:10, a.giammarchi wrote: > On ...
3 days, 7 hours ago (2018-02-15 14:28:25 UTC) #4
a.giammarchi
https://codereview.adblockplus.org/29692555/diff/29692556/popup.html File popup.html (left): https://codereview.adblockplus.org/29692555/diff/29692556/popup.html#oldcode86 popup.html:86: <span class="i18n_stats_share_title"></span> On 2018/02/15 14:28:24, saroyanm wrote: > On ...
3 days, 5 hours ago (2018-02-15 16:02:43 UTC) #5
a.giammarchi
FYI for some reason HG decided these two where different but my current exported diff ...
3 days, 5 hours ago (2018-02-15 16:04:51 UTC) #6
saroyanm
On 2018/02/15 16:04:51, a.giammarchi wrote: > FYI for some reason HG decided these two where ...
3 days, 5 hours ago (2018-02-15 16:31:25 UTC) #7
kzar
Can't we also remove the strings "stats_over", "stats_share_download" and "stats_share_message" now? Also Thomas do you ...
2 days, 3 hours ago (2018-02-16 18:19:06 UTC) #8
kzar
2 days, 3 hours ago (2018-02-16 18:26:32 UTC) #9
Oh, I reviewed this using the patch that Andrea emailed over to me. But it looks
like there's a problem on this review. 

Andrea did you upload the entire change for the second patch set? With Rietveld
you have to upload the entire change every time, Rietveld then takes care of
figuring out the inter-diffs. I ask since I can only see the popup.js changes in
the first patch set.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5