Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(305)

Issue 29692555: Issue 5613 - Removal of social media: Share this number (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 1 week ago by a.giammarchi
Modified:
8 months ago
CC:
Sebastian Noack
Visibility:
Public.

Description

Issue #5613 - Removal of social media: Share this number

Patch Set 1 #

Total comments: 8

Patch Set 2 : Addressed Manvel and Dave's feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -139 lines) Patch
M _locales/en_US/messages.json View 1 2 chunks +0 lines, -17 lines 0 comments Download
M popup.html View 1 chunk +0 lines, -9 lines 0 comments Download
M popup.js View 4 chunks +0 lines, -67 lines 0 comments Download
M skin/popup.css View 1 chunk +0 lines, -46 lines 0 comments Download
M skin/popup.png View 1 Binary file 0 comments Download

Messages

Total messages: 14
a.giammarchi
As mentioned further down the #5613 ticket, we don't want to show social media buttons ...
8 months, 1 week ago (2018-02-08 12:27:04 UTC) #1
saroyanm
https://codereview.adblockplus.org/29692555/diff/29692556/popup.html File popup.html (left): https://codereview.adblockplus.org/29692555/diff/29692556/popup.html#oldcode86 popup.html:86: <span class="i18n_stats_share_title"></span> We still have this String in the ...
8 months, 1 week ago (2018-02-14 17:19:47 UTC) #2
a.giammarchi
one answer + one question (extra clarification) https://codereview.adblockplus.org/29692555/diff/29692556/popup.html File popup.html (left): https://codereview.adblockplus.org/29692555/diff/29692556/popup.html#oldcode86 popup.html:86: <span class="i18n_stats_share_title"></span> ...
8 months ago (2018-02-15 09:43:10 UTC) #3
saroyanm
https://codereview.adblockplus.org/29692555/diff/29692556/popup.html File popup.html (left): https://codereview.adblockplus.org/29692555/diff/29692556/popup.html#oldcode86 popup.html:86: <span class="i18n_stats_share_title"></span> On 2018/02/15 09:43:10, a.giammarchi wrote: > On ...
8 months ago (2018-02-15 14:28:25 UTC) #4
a.giammarchi
https://codereview.adblockplus.org/29692555/diff/29692556/popup.html File popup.html (left): https://codereview.adblockplus.org/29692555/diff/29692556/popup.html#oldcode86 popup.html:86: <span class="i18n_stats_share_title"></span> On 2018/02/15 14:28:24, saroyanm wrote: > On ...
8 months ago (2018-02-15 16:02:43 UTC) #5
a.giammarchi
FYI for some reason HG decided these two where different but my current exported diff ...
8 months ago (2018-02-15 16:04:51 UTC) #6
saroyanm
On 2018/02/15 16:04:51, a.giammarchi wrote: > FYI for some reason HG decided these two where ...
8 months ago (2018-02-15 16:31:25 UTC) #7
kzar
Can't we also remove the strings "stats_over", "stats_share_download" and "stats_share_message" now? Also Thomas do you ...
8 months ago (2018-02-16 18:19:06 UTC) #8
kzar
Oh, I reviewed this using the patch that Andrea emailed over to me. But it ...
8 months ago (2018-02-16 18:26:32 UTC) #9
a.giammarchi
On 2018/02/16 18:26:32, kzar wrote: > Oh, I reviewed this using the patch that Andrea ...
8 months ago (2018-02-19 08:37:55 UTC) #10
a.giammarchi
Patch Set 2 - Cleaned up previous patch 2 and addressed Manvel and Dave's feedback.
8 months ago (2018-02-19 09:50:24 UTC) #11
kzar
LGTM
8 months ago (2018-02-19 09:54:19 UTC) #12
saroyanm
LGTM
8 months ago (2018-02-20 11:35:22 UTC) #13
kzar
8 months ago (2018-02-20 12:01:22 UTC) #14
Message was sent while issue was closed.
https://hg.adblockplus.org/adblockpluschrome/rev/b93c23bea12b
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5