Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29692574: Issue 6280 - Check that we don't return invalid entries (Closed)

Created:
Feb. 9, 2018, 2 a.m. by hub
Modified:
Feb. 12, 2018, 5 p.m.
Reviewers:
sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 6280 - Check that we don't return invalid entries

Patch Set 1 #

Total comments: 4

Patch Set 2 : Removed duplicate test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M test/compiled/StringMap.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5
hub
Feb. 9, 2018, 2 a.m. (2018-02-09 02:00:36 UTC) #1
sergei
https://codereview.adblockplus.org/29692574/diff/29692575/test/compiled/StringMap.cpp File test/compiled/StringMap.cpp (right): https://codereview.adblockplus.org/29692574/diff/29692575/test/compiled/StringMap.cpp#newcode34 test/compiled/StringMap.cpp:34: EXPECT_EQ(map.begin(), map.end()); It seems this line is redundant because ...
Feb. 12, 2018, 8:50 a.m. (2018-02-12 08:50:05 UTC) #2
sergei
https://codereview.adblockplus.org/29692574/diff/29692575/test/compiled/StringMap.cpp File test/compiled/StringMap.cpp (right): https://codereview.adblockplus.org/29692574/diff/29692575/test/compiled/StringMap.cpp#newcode38 test/compiled/StringMap.cpp:38: EXPECT_NE(map.begin(), map.end()); On 2018/02/12 08:50:05, sergei wrote: > That's ...
Feb. 12, 2018, 8:54 a.m. (2018-02-12 08:54:28 UTC) #3
hub
https://codereview.adblockplus.org/29692574/diff/29692575/test/compiled/StringMap.cpp File test/compiled/StringMap.cpp (right): https://codereview.adblockplus.org/29692574/diff/29692575/test/compiled/StringMap.cpp#newcode34 test/compiled/StringMap.cpp:34: EXPECT_EQ(map.begin(), map.end()); On 2018/02/12 08:50:05, sergei wrote: > It ...
Feb. 12, 2018, 2:20 p.m. (2018-02-12 14:20:25 UTC) #4
sergei
Feb. 12, 2018, 4:12 p.m. (2018-02-12 16:12:08 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld