Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(61)

Issue 29693555: Issue 5813 - Check also window.doNotTrack to properly support Edge (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by a.giammarchi
Modified:
3 months ago
Visibility:
Public.

Description

Issue 5813 - Check also window.doNotTrack to properly support Edge

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M desktop-options.js View 2 chunks +6 lines, -4 lines 1 comment Download

Messages

Total messages: 2
a.giammarchi
As mentioned by Manvel: https://codereview.adblockplus.org/29673576/diff/29689576/desktop-options.js#newcode1084
3 months, 1 week ago (2018-02-09 09:03:08 UTC) #1
saroyanm
3 months ago (2018-02-13 18:57:24 UTC) #2
LGTM

https://codereview.adblockplus.org/29693555/diff/29693556/desktop-options.js
File desktop-options.js (right):

https://codereview.adblockplus.org/29693555/diff/29693556/desktop-options.js#...
desktop-options.js:921: setElementText(E("tracking-warning-1"),
"options_tracking_warning_1",
Note: This changes are already pushed
(https://hg.adblockplus.org/adblockplusui/file/tip/desktop-options.js#l917),
Please do not forget to re-base before pushing the commit.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5