Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(307)

Issue 29693558: Issue 6009 - Convert URLs into domains when adding domain to whitelist (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 1 week ago by a.giammarchi
Modified:
8 months, 1 week ago
Visibility:
Public.

Description

Issue 6009 - Convert URLs into domains when adding domain to whitelist

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M desktop-options.js View 2 chunks +7 lines, -5 lines 1 comment Download

Messages

Total messages: 2
a.giammarchi
This is an attempt to simplify UX when whitelisting urls. https://gitlab.com/eyeo/spec/merge_requests/101/diffs?commit_id=dbbe851d5d0bf694f1e1a6245cad1ad46b93584f The URL API is ...
8 months, 1 week ago (2018-02-09 10:19:45 UTC) #1
saroyanm
8 months, 1 week ago (2018-02-14 16:31:06 UTC) #2
LGTM with note/detail

https://codereview.adblockplus.org/29693558/diff/29693559/desktop-options.js
File desktop-options.js (right):

https://codereview.adblockplus.org/29693558/diff/29693559/desktop-options.js#...
desktop-options.js:921: setElementText(E("tracking-warning-1"),
"options_tracking_warning_1",
Detail: Please do not forget to rebase before pushing the change.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5