includes/styles.tmpl - Issue 29693561: Noissue - Update font-family to Source Sans Pro on abp.org

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: includes/styles.tmpl

Issue 29693561: Noissue - Update font-family to Source Sans Pro on abp.org (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org

Patch Set: Update licence file Created March 13, 2018, 1:48 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <link rel="stylesheet" href="/css/defaults.css">	1 <link rel="stylesheet" href="/css/defaults.css">

	2 <link rel="stylesheet" href="/css/fonts.css">
	juliandoucette 2018/03/14 17:08:38 Why a separate file? Why a separate file? saroyanm 2018/03/14 17:56:30 Ideally this will go to the websites default to im Show quoted text On 2018/03/14 17:08:38, juliandoucette wrote: > Why a separate file? Ideally this will go to the websites default to import it for multilingual websites. Note: We use this file in UI separately in order to load in multiple pages, but I don't think you have this need in current repo. Not necessarily this needs to be a separate file here. ire 2018/03/14 18:10:31 I did it this way because it just seemed cleaner t Show quoted text On 2018/03/14 17:08:38, juliandoucette wrote: > Why a separate file? I did it this way because it just seemed cleaner to separate it. Same the defaults css is separate (I think, anyway)? Also, when we implement the build step here everything will be in one file. juliandoucette 2018/03/14 18:18:00 Yes and no. I separated default.css so that I coul Show quoted text On 2018/03/14 18:10:31, ire wrote: > On 2018/03/14 17:08:38, juliandoucette wrote: > > Why a separate file? > > I did it this way because it just seemed cleaner to separate it. Same the > defaults css is separate (I think, anyway)? Yes and no. I separated default.css so that I could update default.css when website-defaults updates without seeming like I'd changed main.css. Show quoted text > Also, when we implement the build step here everything will be in one file. Agreed. --- I'd prefer to update website-defaults and then update defaults.css in web.adblockplus.org in order to include this CSS in defaults.css. But that's a super-NIT preference. It only matters in the rare case that a user who has a bad connection is having a hard time downloading this small file (which will rarely if ever happen). ire 2018/03/15 08:30:48 On 2018/03/14 18:18:00, juliandoucette wrote: On 2018/03/14 18:18:00, juliandoucette wrote: Show quoted text > I'd prefer to update website-defaults and then update defaults.css in > http://web.adblockplus.org in order to include this CSS in defaults.css. But that's a > super-NIT preference. It only matters in the rare case that a user who has a bad > connection is having a hard time downloading this small file (which will rarely > if ever happen). I agree, but adding it to website-defaults may not be so straightforward since we will probably have to make the path to the font files configurable. I will push this as it is for now and open a separate review for that
2 <link rel="stylesheet" href="/css/main.css">	3 <link rel="stylesheet" href="/css/main.css">

OLD	NEW

« no previous file with comments | « no previous file | static/css/fonts.css » ('j') | static/css/fonts.css » ('J')