Noissue - Add crowdin api config support

tests/crowdin_mock_api.py

 import os
-
-from collections import namedtuple
 
 from flask import Flask, send_from_directory, jsonify, request
 
 app = Flask('mock_api')
+
+
+def load(rootdir, zipdir):
+    app.request_log = []
+    app.config['zipdir'] = zipdir
+    app.config['info'] = {'files': [], 'languages': []}
+    app.config['supported_languages'] = []
+
+    for root, locales, files in os.walk(rootdir):
+        for locale in locales:
+            files = []
+            app.config['supported_languages'].append({'crowdin_code': locale})
+            app.config['info']['languages'].append({
+                'code': locale,
+                'can_translate': 1,
+                'can_approve': 1,
+            })
+
+            for translations in os.listdir(os.path.join(root, locale)):
+                files.append({'name': translations, 'node_type': 'file'})
+
+            app.config['info']['files'].append({
+                'name': locale,
+                'files': files,
+                'node_type': 'directory',
+            })
+
+    return app
 
 
 @app.before_request
 def log_request_info():
     app.request_log.append((request.url, str(request.get_data())))
 
 
 @app.route('/api/project/test/info', methods=['GET'])
 def info():
     return jsonify(app.config['info'])
 
 
 @app.route('/api/project/test/edit-project', methods=['POST'])
 def edit():
     return jsonify()
 
 
 @app.route('/api/project/test/supported-languages', methods=['GET'])
 def supported_langs():
-    return jsonify(app.config['languages'])
+    return jsonify(app.config['supported_languages'])
 
 
 @app.route('/api/project/test/add-file', methods=['POST'])
 def add_file():
     app.string = request.get_data()
     return jsonify()
 
 
 @app.route('/api/project/test/upload-translation', methods=['POST'])
 def upload_translation():
@@ skipping 10 matching lines @@
     return jsonify()
 
 
 @app.route('/api/project/test/export', methods=['GET'])
 def export():
     return jsonify({'success': {'status': 'skipped'}})
 
 
 @app.route('/api/project/test/download/all.zip', methods=['GET'])
 def get_zip():
-    return send_from_directory('', 'all.zip')
-
-
-Locale = namedtuple('Locale', ['name', 'node_type', 'files'])
-File = namedtuple('File', ['name', 'node_type'])
-Language = namedtuple('Language', ['code', 'can_approve', 'can_translate'])
-Supported = namedtuple('Supported', ['crowdin_code'])

[Vasily Kuznetsov, 2018/03/05 17:21:32]

Maybe rename this to `SupportedLanguage`? Otherwise it's not very clear what
this is.

-
-
-class CrowdinMock:
-    def __init__(self, locales_root):
-        self.info = {'files': [], 'languages': []}
-        self.languages = []
-        self.load(locales_root)
-
-    def load(self, filepath):
-        for root, locales, files in os.walk(filepath):
-            for locale in locales:
-                files = []
-                self.info['languages'].append(Language(locale, 1, 1))
-                self.languages.append(Supported(locale))
-                for translations in os.listdir(os.path.join(root, locale)):
-                    filenode = File(translations, 'file')
-                    files.append(filenode._asdict())
-                localenode = Locale(locale, 'directory', tuple(files))

[Vasily Kuznetsov, 2018/03/05 17:21:32]

Why are you converting it to tuple here? Seems like naturally this thing is more
of a list, no?

[Jon Sonesen, 2018/03/06 02:30:18]

Acknowledged.

-                self.info['files'].append(localenode)
-
-    def run(self):
-        app.request_log = []
-        self.info['files'] = [i._asdict() for i in self.info['files']]

[Vasily Kuznetsov, 2018/03/05 17:21:32]

It seems like this conversion is basically part of initialization. Maybe it
makes more sense to move it into `load`?

Another thought: the named tuples look kind of neat but here you're  converting
them to dicts and then the dicts are what's actually used. Perhaps it would be
easier to just create things as dicts in the first place? We'd get rid of the
class declarations in lines 61-64, the code in `load` would be a bit more
verbose, but perhaps a bit easier to follow since you'd know which value goes
into which key of the dict, and finally the converting code here would not be
needed at all. What do you think?

[Jon Sonesen, 2018/03/06 02:30:18]

Acknowledged.

-        self.info['languages'] = [i._asdict() for i in self.info['languages']]
-        app.config['info'] = self.info
-        app.config['languages'] = [i._asdict() for i in self.languages]
-        self.app = app
+    return send_from_directory(app.config['zipdir'], 'all.zip')