Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/css/index.css

Issue 29695555: Fixes #6 - Add media mention banner (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Left Patch Set: Created Feb. 12, 2018, 11:26 a.m.
Right Patch Set: Undo change to full-width layout Created Feb. 26, 2018, 8:31 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « includes/index.tmpl ('k') | static/css/index-desktop.css » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 #content 1 #content
2 { 2 {
3 padding-top: 5em; 3 padding-top: 5em;
4 margin: 0 auto; 4 margin: 0 auto;
5 } 5 }
6 6
7 #key-facts h1 7 #key-facts h1
8 { 8 {
9 font-size: 16px; 9 font-size: 16px;
10 } 10 }
(...skipping 674 matching lines...) Expand 10 before | Expand all | Expand 10 after
685 background-color: #fff; 685 background-color: #fff;
686 border: 2px solid #a1a1a1; 686 border: 2px solid #a1a1a1;
687 } 687 }
688 688
689 #ready-for-windows-notice 689 #ready-for-windows-notice
690 { 690 {
691 margin-bottom: 30px; 691 margin-bottom: 30px;
692 } 692 }
693 693
694 /****************************************************************************** 694 /******************************************************************************
695 * #media 695 * #media
juliandoucette 2018/02/19 14:15:56 Detail/TOL: This widget also appears on eyeo.com.
ire 2018/02/20 10:49:05 Noted & Agreed. Is there something in particular y
juliandoucette 2018/02/21 11:22:53 Not specifically. Ideally, the solution that you i
ire 2018/02/22 08:43:52 Ack. The layout between the two sites is noticeabl
696 *****************************************************************************/ 696 *****************************************************************************/
697 697
698 #media-section { clear: both; }
699
698 #media-header h2, 700 #media-header h2,
699 #media-list 701 #media-list
700 { 702 {
701 margin: 0; 703 margin: 0;
702 } 704 }
703 705
704 #media-header 706 #media-header
705 { 707 {
706 margin-bottom: 2em; 708 margin-bottom: 2em;
707 } 709 }
708 710
709 #media-header h2 711 #media-header h2
710 { 712 {
711 font-size: 100%; 713 font-size: 1em;
juliandoucette 2018/02/19 14:15:57 Why 100% instead of 1em?
ire 2018/02/20 10:49:05 I have no idea lol. Changed.
712 font-weight: normal; 714 font-weight: normal;
713 text-transform: uppercase; 715 text-transform: uppercase;
714 } 716 }
715 717
716 #media-list li 718 #media-list li
717 { 719 {
718 display: inline-block; 720 display: inline-block;
719 } 721 }
720 722
721 #media-list img 723 #media-list img
722 { 724 {
723 max-width: 5em; 725 max-width: 10em;
juliandoucette 2018/02/19 14:15:56 Why max heigh/width instead of *just* hight/width?
ire 2018/02/20 10:49:05 Because not all the images will have the same heig
juliandoucette 2018/02/21 11:22:54 Acknowledged.
724 max-height: 3em; 726 max-height: 3em;
725 margin: 0 1em 1em; 727 margin: 0 1em 1em;
726 } 728 }
727 729
728 #media-list a 730 #media-list a
729 { 731 {
730 position: relative; 732 position: relative;
731 display: block; 733 display: block;
732 } 734 }
733 735
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
765 } 767 }
766 768
767 #media-list li 769 #media-list li
768 { 770 {
769 display: table-cell; 771 display: table-cell;
770 vertical-align: middle; 772 vertical-align: middle;
771 } 773 }
772 774
773 #media-list img 775 #media-list img
774 { 776 {
775 margin: 0 2em; 777 margin: 0 2em;
juliandoucette 2018/02/19 14:15:57 Is this meant to make not display:flex look a litt
ire 2018/02/20 10:49:04 It's for both cases, we need some space around eac
juliandoucette 2018/02/21 11:22:53 I was confused because the space applied to each i
ire 2018/02/22 08:43:52 Acknowledged.
776 } 778 }
777 } 779 }
778 780
779 @media (min-width: 992px) 781 @media (min-width: 992px)
780 { 782 {
781 #media { 783 #media {
782 display: table; 784 display: table;
783 width: 100%; 785 width: 100%;
784 } 786 }
785 787
786 #media-header, 788 #media-header,
787 #media-list 789 #media-list
788 { 790 {
789 display: table-cell; 791 display: table-cell;
790 vertical-align: middle; 792 vertical-align: middle;
791 width: auto; 793 width: auto;
792 } 794 }
793 795
794 #media-header 796 #media-header
795 { 797 {
796 margin-bottom: 0; 798 margin-bottom: 0;
797 } 799 }
798 800
799 #media-list { direction: rtl; } 801 #media-list { direction: rtl; }
juliandoucette 2018/02/19 14:15:57 Why are these necessary?
ire 2018/02/20 10:49:05 To align the list items to the right if flex is no
juliandoucette 2018/02/21 11:22:53 I think that you should be able to make them ident
ire 2018/02/22 08:43:52 I was having trouble achieving the exact same spac
juliandoucette 2018/02/23 13:46:17 Agreed.
800 [dir="rtl"] #media-list { direction: ltr; } 802 [dir="rtl"] #media-list { direction: ltr; }
801 803
802 @supports (display: flex) 804 @supports (display: flex)
juliandoucette 2018/02/19 14:15:57 There seems to be too little space between items w
ire 2018/02/20 10:49:05 How much space should there be? The only reason th
juliandoucette 2018/02/21 11:22:53 See answer above. This may or may not be an issue
803 { 805 {
804 #media-list 806 #media-list
805 { 807 {
806 display: flex; 808 display: flex;
807 justify-content: space-between; 809 justify-content: space-between;
808 align-items: center; 810 align-items: center;
809 } 811 }
810 } 812 }
811 813
812 } 814 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld