Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(64)

Issue 29695580: Issue 5093 - Indicate whether request in devtools panel belongs to tab (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by a.giammarchi
Modified:
2 weeks, 2 days ago
Visibility:
Public.

Description

Issue 5093 - Indicate whether request in devtools panel belongs to tab Abandoned, as described in the trac issue.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 8

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -37 lines) Patch
M devtools-panel.html View 1 2 3 4 5 6 7 1 chunk +13 lines, -1 line 0 comments Download
M devtools-panel.js View 1 2 3 4 5 6 7 2 chunks +58 lines, -26 lines 0 comments Download
M skin/devtools-panel.css View 1 2 3 4 5 6 7 2 chunks +36 lines, -10 lines 0 comments Download

Messages

Total messages: 7
a.giammarchi
In order to drop the background image hack/work around I've used placeholders and everything seems ...
3 months, 1 week ago (2018-02-12 16:40:49 UTC) #1
a.giammarchi
After further investigation, I have realised that both record-update and record-remove use a message.index mechanism ...
3 months ago (2018-02-13 12:31:48 UTC) #2
a.giammarchi
Latest update uses `request.docDomain` to distinguish between background tabs and others. Also update and remove ...
3 months ago (2018-02-13 13:36:46 UTC) #3
Thomas Greiner
https://codereview.adblockplus.org/29695580/diff/29697579/devtools-panel.html File devtools-panel.html (right): https://codereview.adblockplus.org/29695580/diff/29697579/devtools-panel.html#newcode79 devtools-panel.html:79: <tr id="background-items"> This implementation appears to cause a bit ...
2 months, 3 weeks ago (2018-02-28 18:18:09 UTC) #4
a.giammarchi
https://codereview.adblockplus.org/29695580/diff/29697579/devtools-panel.js File devtools-panel.js (right): https://codereview.adblockplus.org/29695580/diff/29697579/devtools-panel.js#newcode188 devtools-panel.js:188: /** On 2018/02/28 18:18:08, Thomas Greiner wrote: > In ...
2 months, 3 weeks ago (2018-02-28 19:07:13 UTC) #5
a.giammarchi
https://codereview.adblockplus.org/29695580/diff/29697579/devtools-panel.html File devtools-panel.html (right): https://codereview.adblockplus.org/29695580/diff/29697579/devtools-panel.html#newcode79 devtools-panel.html:79: <tr id="background-items"> On 2018/02/28 18:18:08, Thomas Greiner wrote: > ...
2 months, 2 weeks ago (2018-03-02 09:38:21 UTC) #6
a.giammarchi
2 months, 2 weeks ago (2018-03-02 15:56:53 UTC) #7
There is one blocker (#6402) and one missing information (what are dark theme
colors for background items?) but I'd like to know if the current version is
better than before.

Key changes:

  * simplified state handling via JS, no hacks needed
  * no placeholders, just table TRs to deal with
  * all operations via index works through a single records set

Performance over long sessions with hundreds of rows seems to be more than
reasonable.

Hints or suggested improvements appreciated.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5