Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(382)

Issue 29695580: Issue 5093 - Indicate whether request in devtools panel belongs to tab

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 days, 5 hours ago by a.giammarchi
Modified:
4 days, 11 hours ago
Visibility:
Public.

Description

Issue 5093 - Indicate whether request in devtools panel belongs to tab

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -24 lines) Patch
M devtools-panel.html View 1 chunk +3 lines, -0 lines 0 comments Download
M devtools-panel.js View 1 2 3 4 5 6 4 chunks +100 lines, -11 lines 0 comments Download
M skin/devtools-panel.css View 1 2 3 4 chunks +27 lines, -13 lines 0 comments Download

Messages

Total messages: 3
a.giammarchi
In order to drop the background image hack/work around I've used placeholders and everything seems ...
6 days, 5 hours ago (2018-02-12 16:40:49 UTC) #1
a.giammarchi
After further investigation, I have realised that both record-update and record-remove use a message.index mechanism ...
5 days, 9 hours ago (2018-02-13 12:31:48 UTC) #2
a.giammarchi
5 days, 8 hours ago (2018-02-13 13:36:46 UTC) #3
Latest update uses `request.docDomain` to distinguish between background tabs
and others.

Also update and remove records now are reflected within the panel through rows,
even if split.

I need to double check if docDomain is enough or, eventually, to ask changes in
devtools.js too.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5