Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(59)

Issue 29696595: Noissue - Use angle brackets include for gtest (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by hub
Modified:
2 months, 3 weeks ago
Reviewers:
sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Noissue - Use angle brackets include for gtest

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M test/compiled/RegExp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M test/compiled/String.cpp View 1 chunk +1 line, -1 line 0 comments Download
M test/compiled/StringMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M test/compiled/abptest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
hub
3 months ago (2018-02-13 15:51:08 UTC) #1
sergei
What about "compiled/String.h" and others?
3 months ago (2018-02-13 16:03:11 UTC) #2
hub
On 2018/02/13 16:03:11, sergei wrote: > What about "compiled/String.h" and others? They don't have gtest. ...
3 months ago (2018-02-13 16:14:29 UTC) #3
hub
On 2018/02/13 16:14:29, hub wrote: > On 2018/02/13 16:03:11, sergei wrote: > > What about ...
3 months ago (2018-02-13 16:16:08 UTC) #4
sergei
On 2018/02/13 16:16:08, hub wrote: > On 2018/02/13 16:14:29, hub wrote: > > On 2018/02/13 ...
3 months ago (2018-02-14 15:00:12 UTC) #5
hub
On 2018/02/14 15:00:12, sergei wrote: > I think we need to discuss it, so below ...
3 months ago (2018-02-14 15:53:54 UTC) #6
sergei
On 2018/02/14 15:53:54, hub wrote: > ... Since adblockpluscore has no public headers, we should ...
2 months, 3 weeks ago (2018-02-27 15:41:10 UTC) #7
hub
2 months, 3 weeks ago (2018-02-27 16:31:34 UTC) #8
On 2018/02/27 15:41:10, sergei wrote:
> On 2018/02/14 15:53:54, hub wrote:
> > ... Since adblockpluscore has no public headers, we should specify all its
> headers
> in ""...
> I think we can use that reasoning so far but in general I'm not convinced :)
> LGTM

For the record, my goal in this patch was just to bring consistency with the
other files.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5