Issue 6388 - Wrap inherited function properties as well

polyfill.js

Index: polyfill.js
diff --git a/polyfill.js b/polyfill.js
index f80c98f6ee6efed6b1da4d2fca0107723985f736..fb11bfad187b30ebd060878c748d3fad9ccfb781 100644
--- a/polyfill.js
+++ b/polyfill.js
@@ -78,7 +78,13 @@
     if (!func)
       return;
 
-    let descriptor = Object.getOwnPropertyDescriptor(object, name);
+    let descriptor;
+    let objectProto = object;
+    do

[Manish Jethani, 2018/02/15 13:17:51]

By the way I find this nicer too:

    let descriptor;
    for (let proto = object;
         !(descriptor = Object.getOwnPropertyDescriptor(proto, name));
         proto = Object.getPrototypeOf(proto));

So the extra variable stays local to the loop, and also we don't check if proto
is non-null, only descriptor.

+    {
+      descriptor = Object.getOwnPropertyDescriptor(objectProto, name);
+    }
+    while (!descriptor && (objectProto = Object.getPrototypeOf(objectProto)));

[Manish Jethani, 2018/02/15 09:59:24]

I think we should have a separate function called getPropertyDescriptor right
above wrapAsyncAPIs that looks like this:

  function getPropertyDescriptor(object, name)
  {
    return Object.getOwnPropertyDescriptor(object, name) ||
           getPropertyDescriptor(Object.getPrototypeOf(object), name);
  }

This is elegant and will not be a performance issue like recursion normally is
since the prototype chain is not very long.

Note that Object.getPrototypeOf here is guaranteed to return non-null (since we
already checked that the object contains the property), we can avoid that check.

 
     delete descriptor["get"];
     delete descriptor["set"];