Issue 6389 - ABP for Samsung Internet Crashes when closed on specific devices

adblockplussbrowser/src/main/java/org/adblockplus/sbrowser/contentblocker/engine/EngineService.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 20 matching lines @@
 
   private volatile Engine engine = null;
   private volatile boolean isInitialized = false;
   private Throwable failureCause = null;
   private static final LinkedBlockingQueue<EngineCreatedCallbackWrapper> ON_CREATED_CALLBACKS =
       new LinkedBlockingQueue<>();
 
   @Override
   public int onStartCommand(Intent intent, int flags, int startId)
   {
-    return Service.START_STICKY;
+    return Service.START_NOT_STICKY;

[anton, 2018/02/21 08:05:35]

it's not clear why it happens only on Google Pixel 1.
NOT_STICKY requires the service be started with `startService()`  each time and
i can't see related change (already working this way?).

[jens, 2018/02/21 09:25:55]

START_NOT_STICK does not trigger the service again until the next explicit call
to Context.startService(Intent). See also my comment in the trac ticket.

   }
 
   /**
    * The callback gets executed on the UI thread.
    *
    * @param context
    * @param callback
    */
   public static void startService(final Context context, final OnEngineCreatedCallback callback)
   {
@@ skipping 128 matching lines @@
     final boolean runOnUiThread;
 
     public EngineCreatedCallbackWrapper(final OnEngineCreatedCallback callback,
         final boolean runOnUiThread)
     {
       this.callback = callback;
       this.runOnUiThread = runOnUiThread;
     }
   }
 }