Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: includes/scripts/initialize-videos.html

Issue 29703633: Noissue - Abstracted embedded video for use in blog (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Patch Set: Moved no-js application and iframe height+width Created Feb. 20, 2018, 10:35 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 <script>
2 document.addEventListener("DOMContentLoaded", function(event)
ire 2018/02/21 09:11:29 Why have this in a separate file? We can check for
juliandoucette 2018/02/21 10:35:18 I prefer to define a class/module in one file and
ire 2018/02/22 09:25:41 (Forgot to say that this is a NIT) Is there ever
juliandoucette 2018/02/23 13:31:07 I take your point. Thank you for explaining / push
ire 2018/02/26 18:33:18 You're welcome :)
3 {
4 window.videos = [].slice.call(document.querySelectorAll(".video-parent"))
5 .map(function(parent) {return new Video(parent);});
6 });
7 </script>
OLDNEW
« no previous file with comments | « includes/index.tmpl ('k') | pages/test.html » ('j') | static/css/video.css » ('J')

Powered by Google App Engine
This is Rietveld