Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: pages/test.html

Issue 29703633: Noissue - Abstracted embedded video for use in blog (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Patch Set: Addressed #7, moved video* to main*, and refactored Video class Created Feb. 23, 2018, 1:30 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 title=Video test
2
3 <head>
4 <link rel="stylesheet" href="/css/video.css" />
5 <script src="/js/video.js"></script>
6 </head>
7
8 <div class="video-parent contains-disclaimer">
9 <a
10 class="video-link"
11 target="_blank"
12 href="https://www.youtube-nocookie.com/embed/pVYtzF5SemU?html5=1&amp;autohid e=1&amp;enablejsapi=1&amp;controls=2&amp;fs=1&amp;modestbranding=1&amp;rel=0&amp ;showinfo=0&amp;theme=light&amp;autoplay=1">
13 <img
14 class="video-thumbnail"
15 src="/img/video-thumbnail.jpg"
16 alt="{{ video-alt-text Introduction to Adblock Plus video thumbnail }}">
17 <img
18 class="video-play"
19 src="/img/video-external.png"
20 alt="{{ video-play-alt-text Play Video }}">
21 </a>
22 <p class="video-disclaimer">
23 {{ video-disclaimer Click to play this video. Please note that this video is hosted by YouTube. When this video is played, some personal data is transferred to YouTube. For more information, please review YouTube's <a href='https://www. google.com/intl/en/policies/privacy/' target='_blank'>privacy policy</a>. }}
24 </p>
25 </div>
26
27 <div class="video-parent contains-disclaimer" style="max-width: 520px; margin-to p: 1em;">
28 <a
29 class="video-link"
30 target="_blank"
31 href="https://www.youtube-nocookie.com/embed/pVYtzF5SemU?html5=1&amp;autohid e=1&amp;enablejsapi=1&amp;controls=2&amp;fs=1&amp;modestbranding=1&amp;rel=0&amp ;showinfo=0&amp;theme=light&amp;autoplay=1">
32 <img
33 class="video-thumbnail"
34 src="/img/video-thumbnail.jpg"
35 alt="{{ video-alt-text Introduction to Adblock Plus video thumbnail }}">
36 <img
37 class="video-play"
38 src="/img/video-external.png"
39 alt="{{ video-play-alt-text Play Video }}">
40 </a>
41 <p class="video-disclaimer">
42 {{ video-disclaimer Click to play this video. Please note that this video is hosted by YouTube. When this video is played, some personal data is transferred to YouTube. For more information, please review YouTube's <a href='https://www. google.com/intl/en/policies/privacy/' target='_blank'>privacy policy</a>. }}
43 </p>
44 </div>
OLDNEW

Powered by Google App Engine
This is Rietveld