Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: includes/index.tmpl

Issue 29703633: Noissue - Abstracted embedded video for use in blog (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Left Patch Set: Addressed #7, moved video* to main*, and refactored Video class Created Feb. 23, 2018, 1:30 p.m.
Right Patch Set: Addressed #9 and added urlencode to innerHTML Created Feb. 27, 2018, 1:09 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | static/css/index.css » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 title=Adblock Plus - Surf the web without annoying ads! 1 title=Adblock Plus - Surf the web without annoying ads!
2 noheading=True 2 noheading=True
3 localefile=index 3 localefile=index
4 4
5 {# 5 {#
6 # This file is part of the Adblock Plus website, 6 # This file is part of the Adblock Plus website,
7 # Copyright (C) 2006-present eyeo GmbH 7 # Copyright (C) 2006-present eyeo GmbH
8 # 8 #
9 # Adblock Plus is free software: you can redistribute it and/or modify 9 # Adblock Plus is free software: you can redistribute it and/or modify
10 # it under the terms of the GNU General Public License version 3 as 10 # it under the terms of the GNU General Public License version 3 as
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 <div class="warning-platform firefox">{{"It appears that you are using Mozil la Firefox."|translate("s28")}} <a href="firefox">{{"Switch to Adblock Plus for Firefox."|translate("s29")}}</a></div> 122 <div class="warning-platform firefox">{{"It appears that you are using Mozil la Firefox."|translate("s28")}} <a href="firefox">{{"Switch to Adblock Plus for Firefox."|translate("s29")}}</a></div>
123 <div class="warning-platform chrome">{{"It appears that you are using Google Chrome."|translate("s30")}} <a href="chrome">{{"Switch to Adblock Plus for Chro me."|translate("s31")}}</a></div> 123 <div class="warning-platform chrome">{{"It appears that you are using Google Chrome."|translate("s30")}} <a href="chrome">{{"Switch to Adblock Plus for Chro me."|translate("s31")}}</a></div>
124 <div class="warning-platform android">{{"It appears that you are using Andro id."|translate("s32")}} <a href="android">{{"Switch to Adblock Plus for Android. "|translate("s33")}}</a></div> 124 <div class="warning-platform android">{{"It appears that you are using Andro id."|translate("s32")}} <a href="android">{{"Switch to Adblock Plus for Android. "|translate("s33")}}</a></div>
125 <div class="warning-platform opera">{{"It appears that you are using Opera." |translate("s34")}} <a href="opera">{{"Switch to Adblock Plus for Opera."|transl ate("s35")}}</a></div> 125 <div class="warning-platform opera">{{"It appears that you are using Opera." |translate("s34")}} <a href="opera">{{"Switch to Adblock Plus for Opera."|transl ate("s35")}}</a></div>
126 <div class="warning-platform internet-explorer">{{"It appears that you are u sing Internet Explorer."|translate("s36")}} <a href="internet-explorer">{{"Switc h to Adblock Plus for Internet Explorer."|translate("s37")}}</a></div> 126 <div class="warning-platform internet-explorer">{{"It appears that you are u sing Internet Explorer."|translate("s36")}} <a href="internet-explorer">{{"Switc h to Adblock Plus for Internet Explorer."|translate("s37")}}</a></div>
127 <div class="warning-platform safari">{{"It appears that you are using Safari ."|translate("s38")}} <a href="safari">{{"Switch to Adblock Plus for Safari."|tr anslate("s39")}}</a></div> 127 <div class="warning-platform safari">{{"It appears that you are using Safari ."|translate("s38")}} <a href="safari">{{"Switch to Adblock Plus for Safari."|tr anslate("s39")}}</a></div>
128 <div class="warning-platform yandex-browser">{{"It appears that you are usin g Yandex Browser."|translate("s40")}} <a href="yandex-browser">{{"Switch to Adbl ock Plus for Yandex Browser."|translate("s41")}}</a></div> 128 <div class="warning-platform yandex-browser">{{"It appears that you are usin g Yandex Browser."|translate("s40")}} <a href="yandex-browser">{{"Switch to Adbl ock Plus for Yandex Browser."|translate("s41")}}</a></div>
129 <div class="warning-platform maxthon">{{"It appears that you are using Maxth on."|translate("s42")}} <a href="maxthon">{{"Switch to Adblock Plus for Maxthon. "|translate("s43")}}</a></div> 129 <div class="warning-platform maxthon">{{"It appears that you are using Maxth on."|translate("s42")}} <a href="maxthon">{{"Switch to Adblock Plus for Maxthon. "|translate("s43")}}</a></div>
130 </div> 130 </div>
131 131
132 <div id="home-video" class="video-parent contains-disclaimer"> 132 <div id="home-video" class="video-parent">
ire 2018/02/26 18:33:18 This still has the contains-disclaimer class
juliandoucette 2018/02/27 13:10:39 Good catch.
133 <a class="video-link" target="_blank" href="https://www.youtube-nocookie.com /embed/pVYtzF5SemU?html5=1&amp;autohide=1&amp;enablejsapi=1&amp;controls=2&amp;f s=1&amp;modestbranding=1&amp;rel=0&amp;showinfo=0&amp;theme=light&amp;autoplay=1 "> 133 <a class="video-link" target="_blank" href="https://www.youtube-nocookie.com /embed/pVYtzF5SemU?html5=1&amp;autohide=1&amp;enablejsapi=1&amp;controls=2&amp;f s=1&amp;modestbranding=1&amp;rel=0&amp;showinfo=0&amp;theme=light&amp;autoplay=1 ">
134 <img class="video-thumbnail" src="/img/video-thumbnail.jpg" alt="{{ "Intro duction to Adblock Plus video thumbnail" | translate("video-alt-text") }}"> 134 <img class="video-thumbnail" src="/img/video-thumbnail.jpg" alt="{{ "Intro duction to Adblock Plus video thumbnail" | translate("video-alt-text") }}">
135 <img class="video-play" src="/img/video-external.png" alt="{{ "Play Video" | translate("video-play-alt-text") }}"> 135 <img class="video-play" src="/img/video-external.png" alt="{{ "Play Video" | translate("video-play-alt-text") }}">
136 </a> 136 </a>
137 <p class="video-disclaimer"> 137 <p class="video-disclaimer">
138 {{ "Click to play this video. Please note that this video is hosted by You Tube. When this video is played, some personal data is transferred to YouTube. F or more information, please review YouTube's <a href='https://www.google.com/int l/en/policies/privacy/' target='_blank'>privacy policy</a>." | translate("video- disclaimer") }} 138 {{ "Click to play this video. Please note that this video is hosted by You Tube. When this video is played, some personal data is transferred to YouTube. F or more information, please review YouTube's <a href='https://www.google.com/int l/en/policies/privacy/' target='_blank'>privacy policy</a>." | translate("video- disclaimer") }}
139 </p> 139 </p>
140 </div> 140 </div>
141 141
142 <img id="maxthon-instruction" src="/img/maxthon-instruction.png" alt="{{"Activ ate Adblock Plus in Maxthon"|translate("maxthon-instruction")}}"> 142 <img id="maxthon-instruction" src="/img/maxthon-instruction.png" alt="{{"Activ ate Adblock Plus in Maxthon"|translate("maxthon-instruction")}}">
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 <li> 189 <li>
190 {{"We listen to our users. If an Acceptable Ads proposal is flagged by our community for a legitimate reason, we will remove it from the whitelist."|trans late("footnote-value-users")}} 190 {{"We listen to our users. If an Acceptable Ads proposal is flagged by our community for a legitimate reason, we will remove it from the whitelist."|trans late("footnote-value-users")}}
191 </li> 191 </li>
192 <li> 192 <li>
193 {{"We are able to keep our open source product free by charging large enti ties a fee for whitelisting services. For the other roughly 90 percent of our pa rtners, these services are offered free of charge."|translate("footnote-keep-fre e")}} 193 {{"We are able to keep our open source product free by charging large enti ties a fee for whitelisting services. For the other roughly 90 percent of our pa rtners, these services are offered free of charge."|translate("footnote-keep-fre e")}}
194 </li> 194 </li>
195 </ul> 195 </ul>
196 </div> 196 </div>
197 197
198 <script src="/js/index.js"></script> 198 <script src="/js/index.js"></script>
LEFTRIGHT

Powered by Google App Engine
This is Rietveld