Noissue - Abstracted embedded video for use in blog

static/js/main.js

 "use strict";
 
 (function()
 {
   function initLanguageSelection()
   {
     var locale = document.getElementById("navbar-locale-selected");
 
     // skip if page does not have language selection (EG: blog)
     if (!locale) return;
@@ skipping 84 matching lines @@
     {
       event.preventDefault();
 
       if (this.parent.classList.contains("hide-disclaimer"))
         this.toggleDisclaimer();
       //prevent bypassing the disclaimer via double click
       else if (new Date().getTime() - this.lastClicked > 600)
         this.insertVideo();
     },
 
-    /** Toggle video disclaimer */

[ire, 2018/02/26 18:33:18]

NIT: Unnecessary comment, the function title toggleDisclaimer already says this

[juliandoucette, 2018/02/27 13:10:39]

Agreed.

     toggleDisclaimer: function()
     {
       this.parent.classList.toggle("hide-disclaimer");
       this.lastClicked = new Date().getTime();
     },
 
     /** Replace video thumbnail with video iframe */
     insertVideo: function()
     {
       this.parent.classList.add("hide-disclaimer");
       this.parent.classList.add("has-iframe");
 
       //replace static thumbnail with iframe video
       this.parent.innerHTML =
         "<iframe " +
           "class='video-iframe' " +
           "frameborder=0 " +
           "allowfullscreen " +
-          "src='" + this.src + "'>" +
+          "src='" + encodeURI(this.src) + "'>" +
         "</iframe>";
     }
   };
 
   window.videos = [].slice.call(document.querySelectorAll(".video-parent"))
     .map(function(parent) {return new Video(parent);});
 }());