includes/index/features.html - Issue 29705597: Fixes #7 - Updated benefits section on index page

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: includes/index/features.html

Issue 29705597: Fixes #7 - Updated benefits section on index page (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org

Patch Set: Created Feb. 22, 2018, 9:43 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <div class="container text-center">

	2 <div class="row">

	3 <div class="column one-third">

	4 <img

	5 height="90px"
	ire 2018/02/23 09:58:17 NIT: This size seems to big for smaller devices. NIT: This size seems to big for smaller devices. juliandoucette 2018/02/23 12:41:59 Doesn't look that way to me. I encourage you to br Show quoted text On 2018/02/23 09:58:17, ire wrote: > NIT: This size seems to big for smaller devices. Doesn't look that way to me. I encourage you to bring this up with Jeen if you think so.
	6 width="90px"

	7 src="/img/feature-fast.png"

	8 srcset="/img/feature-fast.svg 2x"

	9 alt="{{ feature-faster-alt[alt text] Rocket }}">

	10 <h2>{{ feature-faster-heading[heading] FASTER, MORE ENJOYABLE BROWSING }}< /h2>
	ire 2018/02/23 09:58:17 NIT: I think the capitalisation should be applied NIT: I think the capitalisation should be applied with CSS juliandoucette 2018/02/23 12:41:59 Agreed. Done. Show quoted text On 2018/02/23 09:58:17, ire wrote: > NIT: I think the capitalisation should be applied with CSS Agreed. Done.
	11 <p>{{ feature-faster-body Block ads that interrupt your browsing experienc e. Say goodbye to video ads, pop-ups, flashing banners and more. Blocking these annoyances means pages load faster. }}</p>
	ire 2018/02/23 09:58:17 TOL: It's not clear from the mockups because the h TOL: It's not clear from the mockups because the headings all happen to take up 2 lines, but it seems like each piece of content (img, heading, paragraph) should take up the same amount of space. i.e. the paragraphs should all start at the same horizontal level. juliandoucette 2018/02/23 12:41:59 Good observation. I'd rather not set a fixed heigh Show quoted text On 2018/02/23 09:58:17, ire wrote: > TOL: It's not clear from the mockups because the headings all happen to take up > 2 lines, but it seems like each piece of content (img, heading, paragraph) > should take up the same amount of space. i.e. the paragraphs should all start at > the same horizontal level. Good observation. I'd rather not set a fixed height on headings because it's a headache to account for smaller screens and translations.
	12 </div>

	13 <div class="column one-third">

	14 <img

	15 height="90px"

	16 width="90px"

	17 src="/img/feature-safe.png"

	18 srcset="/img/feature-safe.svg 2x"

	19 alt="{{ feature-safe-alt[alt text] Padlock }}">

	20 <h2>{{ feature-safe-heading[heading] KEEP YOUR DATA AND DEVICES SAFE }}</h 2>

	21 <p>{{ feature-safe-body With Adblock Plus avoiding tracking and malware is easy. Blocking intrusive ads reduces the risk of "malvertizing" infections. Blo cking tracking stops companies following your online activity. }}</p>

	22 </div>

	23 <div class="column one-third">

	24 <img

	25 height="90px"

	26 width="90px"

	27 src="/img/feature-aa.png"

	28 srcset="/img/feature-aa.svg 2x"

	29 alt="{{ feature-aa-alt[alt text] Checkmark in an octagon }}">

	30 <h2>{{ feature-aa-heading[heading] NOT ALL ADS ARE BAD }}</h2>

	31 <p>{{ feature-aa-body Websites need money to stay free. Support them by al lowing Acceptable Ads (enabled by default). Want to hide all ads? No problem. <a href="acceptable-ads#optout">Learn how</a> }}</p>

	32 </div>

	33 </div>

	34 </div>

OLD	NEW

« includes/index.tmpl ('K') | « includes/index.tmpl ('k') | static/img/feature-aa.png » ('j') | no next file with comments »