static/css/main.css - Issue 29705597: Fixes #7 - Updated benefits section on index page

Delta Between Two Patch Sets: static/css/main.css

Issue 29705597: Fixes #7 - Updated benefits section on index page (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org

Left Patch Set: Addressed #3 and spacing Created Feb. 23, 2018, 12:41 p.m.

Right Patch Set: Moved features and renamed card/card-deck to item/item-group Created Feb. 28, 2018, 7:37 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 *	1 *

2 {	2 {

3 font-family: Arial, sans;	3 font-family: Arial, sans;

4 font-size: 16px;	4 font-size: 16px;

5 }	5 }

6	6

7 body	7 body

8 {	8 {

9 margin: 0;	9 margin: 0;

10 line-height: 1.5;	10 line-height: 1.5;

(...skipping 699 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
710 display: none;	710 display: none;

711 }	711 }

712	712

713 /* overriding display:none above */	713 /* overriding display:none above */

714 #footer #social-list	714 #footer #social-list

715 {	715 {

716 display: block;	716 display: block;

717 }	717 }

718 }	718 }

719	719

720 /* Cards	720 /* Items
ire 2018/02/26 19:01:31 There doesn't seem to me to be anything related to There doesn't seem to me to be anything related to "cards" here. Most styles here are only about spacing. Also, this doesn't appear to be a "card" in the typical sense of a box with a contrasting background. juliandoucette 2018/02/27 13:00:06 Agreed... Wasn't sure what to call it :/ ... Any s Show quoted text On 2018/02/26 19:01:31, ire wrote: > There doesn't seem to me to be anything related to "cards" here. Most styles > here are only about spacing. Also, this doesn't appear to be a "card" in the > typical sense of a box with a contrasting background. Agreed... Wasn't sure what to call it :/ ... Any suggestions? ire 2018/02/28 09:21:54 I'm not sure either. Considering that this may be Show quoted text On 2018/02/27 13:00:06, juliandoucette wrote: > On 2018/02/26 19:01:31, ire wrote: > > There doesn't seem to me to be anything related to "cards" here. Most styles > > here are only about spacing. Also, this doesn't appear to be a "card" in the > > typical sense of a box with a contrasting background. > > Agreed... Wasn't sure what to call it :/ ... Any suggestions? I'm not sure either. Considering that this may be restricted to the benefits section only, maybe we should just use the ID instead? juliandoucette 2018/02/28 19:40:00 How about "item"? Show quoted text On 2018/02/28 09:21:54, ire wrote: > I'm not sure either. Considering that this may be restricted to the benefits > section only, maybe we should just use the ID instead? How about "item"? ire 2018/03/01 09:06:05 I don't think "item" really has much meaning eithe Show quoted text On 2018/02/28 19:40:00, juliandoucette wrote: > On 2018/02/28 09:21:54, ire wrote: > > I'm not sure either. Considering that this may be restricted to the benefits > > section only, maybe we should just use the ID instead? > > How about "item"? I don't think "item" really has much meaning either. Do you think this set of styles will be repeated elsewhere? juliandoucette 2018/03/01 10:34:09 Yes, at least in the almost identical "features" s Show quoted text On 2018/03/01 09:06:05, ire wrote: > I don't think "item" really has much meaning either. Do you think this set of > styles will be repeated elsewhere? Yes, at least in the almost identical "features" section further down on the home page. The idea is: "item" is like "card" except it only provides space instead of border/background and space (acknowledging that I just made that up retrospectively and I don't yet know for sure if it will be useful elsewhere beyond these two examples). ire 2018/03/01 14:15:07 Alright. I'm still not 100% sure about the name "i Show quoted text On 2018/03/01 10:34:09, juliandoucette wrote: > On 2018/03/01 09:06:05, ire wrote: > > I don't think "item" really has much meaning either. Do you think this set of > > styles will be repeated elsewhere? > > Yes, at least in the almost identical "features" section further down on the > home page. The idea is: "item" is like "card" except it only provides space > instead of border/background and space (acknowledging that I just made that up > retrospectively and I don't yet know for sure if it will be useful elsewhere > beyond these two examples). Alright. I'm still not 100% sure about the name "item", but I can't come up with anything better so I think we should stick with it.
721 *****************************************************************************/	721 *****************************************************************************/

722	722

723 .card-deck	723 .item-group,
ire 2018/02/26 19:01:31 Did you mean for there to be a comma after this? Did you mean for there to be a comma after this? juliandoucette 2018/02/27 13:00:06 Yes blush Show quoted text On 2018/02/26 19:01:31, ire wrote: > Did you mean for there to be a comma after this? Yes blush ire 2018/02/28 09:21:54 :P Show quoted text On 2018/02/27 13:00:06, juliandoucette wrote: > On 2018/02/26 19:01:31, ire wrote: > > Did you mean for there to be a comma after this? > > Yes blush :P
724 .card-body	724 .item-body

725 {	725 {

726 margin: 1em 0;	726 margin-top: 1em;

727 }	727 margin-bottom: 1em;

728	728 }

729 .card	729

730 {	730 .item

731 margin: 2em 0 1em 0;	731 {

732 }	732 padding-top: 2em;

733	733 padding-bottom: 2em;

734 .card-heading	734 }

	735

	736 .item-heading

735 {	737 {

736 text-transform: uppercase;	738 text-transform: uppercase;

737 }	739 }

LEFT	RIGHT