package.json - Issue 29705690: Issue 6310 - Start using JavaScript modularization tool

Side by Side Diff: package.json

Issue 29705690: Issue 6310 - Start using JavaScript modularization tool (Closed)

Patch Set: Created Feb. 22, 2018, 5:22 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 {	1 {

2 "name": "adblockplusui",	2 "name": "adblockplusui",

3 "private": true,	3 "private": true,

4 "description": "Adblock Plus UI",	4 "description": "Adblock Plus UI",

5 "scripts": {	5 "scripts": {

6 "lint": "npm run lint:js",	6 "lint": "npm run lint:js",

7 "lint:js": "eslint ./.js ./lib/.js ./ext/*.js",	7 "lint:js": "eslint ./.js ./lib/.js ./ext/*.js",

8 "prepare": "python2 ensure_dependencies.py",	8 "prepare": "python2 ensure_dependencies.py",

9 "start": "http-server"	9 "start": "http-server",
	saroyanm 2018/02/22 19:07:28 Suggestion: What about watching changes while runn Suggestion: What about watching changes while running local server ? Any arguments against it ? I think it's handy when you don't need to run watcher every time separately. a.giammarchi 2018/02/23 08:51:37 IIRC you can have only one output in console throu Show quoted text On 2018/02/22 19:07:28, saroyanm wrote: > Suggestion: What about watching changes while running local server ? > Any arguments against it ? > I think it's handy when you don't need to run watcher every time separately. IIRC you can have only one output in console through cmd1 & cmd2, which one you prefer? I think having possible errors on build visible is key, and I need to double check once you exit both processes are gone. saroyanm 2018/02/23 11:26:16 I agree that build is more important, I have coupl Show quoted text On 2018/02/23 08:51:37, a.giammarchi wrote: > On 2018/02/22 19:07:28, saroyanm wrote: > > Suggestion: What about watching changes while running local server ? > > Any arguments against it ? > > I think it's handy when you don't need to run watcher every time separately. > > IIRC you can have only one output in console through cmd1 & cmd2, which one you > prefer? I think having possible errors on build visible is key, and I need to > double check once you exit both processes are gone. I agree that build is more important, I have couple of suggestions: * Use "concurrently" https://www.npmjs.com/package/concurrently AFAIK it also should care of exit * Make watch during server run optional (this is irregardless of concurrently usage) * Push the way it was(run start and watch separately and revisit this question later on). All of options will work fine with me. a.giammarchi 2018/02/23 12:02:10 current command works just fine and we don't need Show quoted text On 2018/02/23 11:26:16, saroyanm wrote: > On 2018/02/23 08:51:37, a.giammarchi wrote: > > On 2018/02/22 19:07:28, saroyanm wrote: > > > Suggestion: What about watching changes while running local server ? > > > Any arguments against it ? > > > I think it's handy when you don't need to run watcher every time separately. > > > > IIRC you can have only one output in console through cmd1 & cmd2, which one > you > > prefer? I think having possible errors on build visible is key, and I need to > > double check once you exit both processes are gone. > > I agree that build is more important, I have couple of suggestions: > * Use "concurrently" https://www.npmjs.com/package/concurrently AFAIK it also > should care of exit > * Make watch during server run optional (this is irregardless of concurrently > usage) > * Push the way it was(run start and watch separately and revisit this question > later on). > > All of options will work fine with me. current command works just fine and we don't need to handle kill-others cases so I think we can go with this?
	10 "bundle": "npm run bundle:desktop-options",
	saroyanm 2018/02/22 19:07:28 Detail: I think it will be helpful to document in Detail: I think it will be helpful to document in README file how to create a bundle and run watchers. a.giammarchi 2018/02/23 08:51:37 it's a matter of copy and paste using a different Show quoted text On 2018/02/22 19:07:28, saroyanm wrote: > Detail: I think it will be helpful to document in README file how to create a > bundle and run watchers. it's a matter of copy and paste using a different entry point name but surely I can try to explain it on the README.
	11 "bundle:desktop-options": "eslint ./js/*/.js && echo '/* eslint-disable */ // BUNDLED FILE'>./desktop-options.js && browserify --node --no-bundle-external js/desktop-options.js >> ./desktop-options.js",
	saroyanm 2018/02/22 18:54:32 What does double ">>" mean in browserify, I though What does double ">>" mean in browserify, I thought the syntax is something like "destination" > "target" ? a.giammarchi 2018/02/23 08:51:37 as explained by email, > and >> are not browserify Show quoted text On 2018/02/22 18:54:32, saroyanm wrote: > What does double ">>" mean in browserify, I thought the syntax is something like > "destination" > "target" ? as explained by email, > and >> are not browserify features, rather how shell/bash work. saroyanm 2018/02/23 11:26:16 Acknowledged. Show quoted text On 2018/02/23 08:51:37, a.giammarchi wrote: > On 2018/02/22 18:54:32, saroyanm wrote: > > What does double ">>" mean in browserify, I thought the syntax is something > like > > "destination" > "target" ? > > as explained by email, > and >> are not browserify features, rather how > shell/bash work. Acknowledged.
	12 "watch": "npm run watch:desktop-options",

	13 "watch:desktop-options": "watch 'npm run bundle:desktop-options' ./js",

	14 "postinstall": "npm run bundle"

10 },	15 },

11 "devDependencies": {	16 "devDependencies": {

	17 "browserify": "^16.1.0",

12 "eslint": "^4.16.0",	18 "eslint": "^4.16.0",

13 "eslint-config-eyeo": "^2.0.0",	19 "eslint-config-eyeo": "^2.0.0",

14 "http-server": "^0.11.1"	20 "http-server": "^0.11.1",

	21 "watch": "^1.0.2"

15 }	22 }

16 }	23 }

OLD	NEW

« .hgignore ('K') | « js/desktop-options.js ('k') | no next file » | no next file with comments »