Issue 6310 - Start using JavaScript modularization tool

README.md

 Shared Adblock Plus UI code
 ===========================
 
 The user interface elements defined in this repository will be used by various
 Adblock Plus products like Adblock Plus for Firefox. Their functionality can be
 tested within this repository, even though they might not work exactly the same
 as they will do in the final product.
 
 Installing dependencies
 -----------------------
@@ skipping 12 matching lines @@
 * Top-level files:
   * `firstRun.html` and `firstRun.js`: First-run page, see below
   * `i18n.js`: Localization functions, should be included by all pages.
   * `messageResponder.js`: Script to be used on the background page to respond
     to messages sent by UI code.
   * `background.html`, `background.js`: Test implementation of the background
     page, should *not be imported*.
   * `desktop-options.html`, `desktop-options.js`: Options page, see below
   * `subscriptions.xml`: Test subscription data, should *not be imported*
   * `polyfill.js`: Browser API polyfills, should *not be imported*
+* `js` directory: new CommonJS modules/entry-points bundled to produce
+  top level pages. As example, `js/desktop-options.js` produces
+  `./desktop-options.js` [IIFE](https://developer.mozilla.org/en-US/docs/Glossary/IIFE)
+  deployed within the extension.
 * `lib` directory: Modules to be used on the background page to expose
   UI-related functionality.
 * `locale` directory: Localized strings, with one directory per locale. The
   Firefox format for locale identifiers is used (xx-YY where xx is the language
   code and YY the optional region code). The localization strings themselves are
   stored in the JSON format, like the one used by Chrome extensions. There is
   one JSON file per HTML page, file names of HTML page and JSON file should
   match.
 * `skin` directory: CSS files and any additional resources (images and fonts)
   required for these.
@@ skipping 29 matching lines @@
 
 Remember, both `eslint` and `stylelint` can help fixing issues via `--fix` flag.
 
 You can try as example via [npx](https://medium.com/@maybekatz/introducing-npx-an-npm-package-runner-55f7d4bd282b)
 which should be provided automatically when you install `npm`.
 
 ```sh
 npx stylelint --fix skin/real-file-name.css
 ```
 
+Bundling
+--------
+
+As it is for the `desktop-options.js` case, bundling is done via `package.json`
+script entries.
+
+A dedicated script entry, such `bundle:desktop-options`,
+should perform the following operations:
+
+  * ensure source code passes linting
+  * ensure the bundle won't affect future linting operations
+  * ensure `browserify` uses `--node` and `--no-bundle-external` flags
+  * point at the entry point, and output in the top level folder
+
+Accordingly, this is what happens with the `bundle:desktop-options`:
+
+```sh
+# the && operator ensure each step is executed only
+# if the previous one didn't produce an error
+eslint ./js/**/*.js &&
+# browserify doesn't offer a way to prefix with text
+# the file is hence created with eslint disabled and a warning
+echo '/* eslint-disable */// BUNDLED FILE' > ./desktop-options.js &&
+# browserify take an entry point and bundle all its required files
+# outputting the result into ./desktop-options.js
+browserify --node --no-bundle-external js/desktop-options.js >> ./desktop-options.js
+```
+
+For a new bundle, i.e. `mobile-options.js`, simply use the same procedure
+but swap the `desktop-options` file/script name with `mobile-options`.
+
+The main `bundle` script should include each sub-bundle operation.
+
+Watching
+--------
+
+While developing, it is convenient to bundle automatically
+each time a source file is changed.
+
+As a team, we agreed on restructuring JS code inside the js folder,
+so that is watched, and each bundled created, every time there is a changes.
+
+Similarly done for bundles, watches follow the following convention:
+
+a named script entry such `watch:desktop-option` that
+points at the following command:
+
+```sh
+watch 'npm run bundle:desktop-options' ./js
+```
+
+The main `watch` script should include each sub-watch operation.
+
+
 Translations
 ------------
 
 Translations for the strings in this project are managed using the online
 [Crowdin platform][crowdin]. To synchronise with Crowdin you can use the build
 script. To get a list of the possible commands type `./build.py help` at
 the command line. (You will also need the Crowdin API key for the project.)
 
 firstRun.html
 -------------
@@ skipping 43 matching lines @@
   errors when adding new filters on the options page
 * `blockedURLs`: a comma-separated list of URLs that should be considered
   blocked (necessary to test the check for blocked scripts in sharing buttons).
 * `downloadStatus`: sets downloadStatus parameter for filter lists, can be used
   to trigger various filter list download errors
 * `platform=chromium`: shows the opt-out for the developer tools panel
 * `showNotificationUI=true`: simulates user having opted-out of notifications
 
 
 [crowdin]: https://crowdin.com