.hgignore - Issue 29705690: Issue 6310 - Start using JavaScript modularization tool

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: .hgignore

Issue 29705690: Issue 6310 - Start using JavaScript modularization tool (Closed)

Left Patch Set: Created Feb. 22, 2018, 5:22 p.m.

Right Patch Set: Created Feb. 23, 2018, 9:24 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 node_modules/	1 node_modules/

2 desktop-options.js	2 ^desktop-options.js
Thomas Greiner 2018/02/22 18:29:23 Suggestion: Note that this also matches js/desktop Suggestion: Note that this also matches js/desktop-options.js. While this shouldn't cause any issues, it may still be unexpected. Therefore I'd suggest changing it to: ^desktop-options.js Alternatively, you could introduce a dedicated output directory so that we don't have to keep track of each individual file in here. Otherwise we can do that later on. a.giammarchi 2018/02/23 08:51:37 Happy to use the suggested change. Show quoted text On 2018/02/22 18:29:23, Thomas Greiner wrote: > Suggestion: Note that this also matches js/desktop-options.js. While this > shouldn't cause any issues, it may still be unexpected. > > Therefore I'd suggest changing it to: > ^desktop-options.js > > Alternatively, you could introduce a dedicated output directory so that we don't > have to keep track of each individual file in here. Otherwise we can do that > later on. Happy to use the suggested change.
LEFT	RIGHT