Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: package.json

Issue 29705690: Issue 6310 - Start using JavaScript modularization tool (Closed)
Left Patch Set: Created Feb. 22, 2018, 5:22 p.m.
Right Patch Set: Created Feb. 23, 2018, 9:24 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « js/desktop-options.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 { 1 {
2 "name": "adblockplusui", 2 "name": "adblockplusui",
3 "private": true, 3 "private": true,
4 "description": "Adblock Plus UI", 4 "description": "Adblock Plus UI",
5 "scripts": { 5 "scripts": {
6 "lint": "npm run lint:js", 6 "lint": "npm run lint:js",
7 "lint:js": "eslint ./*.js ./lib/*.js ./ext/*.js", 7 "lint:js": "eslint ./*.js ./lib/*.js ./ext/*.js",
8 "prepare": "python2 ensure_dependencies.py", 8 "prepare": "python2 ensure_dependencies.py",
9 "start": "http-server", 9 "start": "http-server & npm run watch",
saroyanm 2018/02/22 19:07:28 Suggestion: What about watching changes while runn
a.giammarchi 2018/02/23 08:51:37 IIRC you can have only one output in console throu
saroyanm 2018/02/23 11:26:16 I agree that build is more important, I have coupl
a.giammarchi 2018/02/23 12:02:10 current command works just fine and we don't need
10 "bundle": "npm run bundle:desktop-options", 10 "bundle": "npm run bundle:desktop-options",
saroyanm 2018/02/22 19:07:28 Detail: I think it will be helpful to document in
a.giammarchi 2018/02/23 08:51:37 it's a matter of copy and paste using a different
11 "bundle:desktop-options": "eslint ./js/**/*.js && echo '/* eslint-disable */ // BUNDLED FILE'>./desktop-options.js && browserify --node --no-bundle-external js/desktop-options.js >> ./desktop-options.js", 11 "bundle:desktop-options": "eslint ./js/**/*.js && echo '/* eslint-disable */ // BUNDLED FILE'>./desktop-options.js && browserify --node --no-bundle-external js/desktop-options.js >> ./desktop-options.js",
saroyanm 2018/02/22 18:54:32 What does double ">>" mean in browserify, I though
a.giammarchi 2018/02/23 08:51:37 as explained by email, > and >> are not browserify
saroyanm 2018/02/23 11:26:16 Acknowledged.
12 "watch": "npm run watch:desktop-options", 12 "watch": "npm run watch:desktop-options",
13 "watch:desktop-options": "watch 'npm run bundle:desktop-options' ./js", 13 "watch:desktop-options": "watch 'npm run bundle:desktop-options' ./js",
14 "postinstall": "npm run bundle" 14 "postinstall": "npm run bundle"
15 }, 15 },
16 "devDependencies": { 16 "devDependencies": {
17 "browserify": "^16.1.0", 17 "browserify": "^16.1.0",
18 "eslint": "^4.16.0", 18 "eslint": "^4.16.0",
19 "eslint-config-eyeo": "^2.0.0", 19 "eslint-config-eyeo": "^2.0.0",
20 "http-server": "^0.11.1", 20 "http-server": "^0.11.1",
21 "watch": "^1.0.2" 21 "watch": "^1.0.2"
22 } 22 }
23 } 23 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld