metadata.chrome - Issue 29705719: Issue 6402 - Split filter hit / request logging out into own API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.chrome

Issue 29705719: Issue 6402 - Split filter hit / request logging out into own API (Closed)

Left Patch Set: Fixed typo and exposed pageId for logged requests Created Feb. 22, 2018, 3:55 p.m.

Right Patch Set: Addressed Manish's feedback Created May 9, 2018, 5:53 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Right: Side by side diff | Download

LEFT	RIGHT
(no file at all)
1 [general]	1 [general]

2 basename = adblockpluschrome	2 basename = adblockpluschrome

3 version = 3.0.4	3 version = 3.0.4

4 author = eyeo GmbH	4 author = eyeo GmbH

5 backgroundScripts = polyfill.js	5 backgroundScripts = polyfill.js

6 ext/common.js	6 ext/common.js

7 ext/background.js	7 ext/background.js

8 lib/compat.js	8 lib/compat.js

9 lib/publicSuffixList.js	9 lib/publicSuffixList.js

10 lib/adblockplus.js	10 lib/adblockplus.js

(...skipping 122 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
133 desktop-options.js = adblockplusui/desktop-options.js	133 desktop-options.js = adblockplusui/desktop-options.js

134 skin/desktop-options.css = adblockplusui/skin/desktop-options.css	134 skin/desktop-options.css = adblockplusui/skin/desktop-options.css

135 updates.html = adblockplusui/updates.html	135 updates.html = adblockplusui/updates.html

136 updates.js = adblockplusui/updates.js	136 updates.js = adblockplusui/updates.js

137 skin/updates.css = adblockplusui/skin/updates.css	137 skin/updates.css = adblockplusui/skin/updates.css

138	138

139 [bundles]	139 [bundles]

140 lib/adblockplus.js =	140 lib/adblockplus.js =

141 adblockpluscore/lib/filterListener.js	141 adblockpluscore/lib/filterListener.js

142 adblockpluscore/lib/synchronizer.js	142 adblockpluscore/lib/synchronizer.js

	143 lib/devtools.js

143 lib/requestBlocker.js	144 lib/requestBlocker.js

144 lib/popupBlocker.js	145 lib/popupBlocker.js

145 lib/subscriptionInit.js	146 lib/subscriptionInit.js

146 lib/filterComposer.js	147 lib/filterComposer.js

147 lib/stats.js	148 lib/stats.js

148 lib/uninstall.js	149 lib/uninstall.js

149 lib/csp.js	150 lib/csp.js

150 lib/cssInjection.js	151 lib/cssInjection.js

151 adblockplusui/messageResponder.js	152 adblockplusui/messageResponder.js

152 include.preload.js =	153 include.preload.js =

153 include.preload.js	154 include.preload.js

154 inject.preload.js	155 inject.preload.js

155 include.postload.js =	156 include.postload.js =

156 subscriptionLink.postload.js	157 subscriptionLink.postload.js

157 composer.postload.js	158 composer.postload.js

158 qunit/tests.js =	159 qunit/tests.js =

159 qunit/common.js	160 qunit/common.js

160 qunit/tests/prefs.js	161 qunit/tests/prefs.js

161 qunit/tests/url.js	162 qunit/tests/url.js

162 qunit/tests/cssEscaping.js	163 qunit/tests/cssEscaping.js

163	164

164 [import_locales]	165 [import_locales]

165 adblockplusui/locale//antiadblockInit.json =	166 adblockplusui/locale//antiadblockInit.json =

166 adblockplusui/locale//common.json =	167 adblockplusui/locale//common.json =

167 adblockplusui/locale//desktop-options.json =	168 adblockplusui/locale//desktop-options.json =

168 adblockplusui/locale//firstRun.json =	169 adblockplusui/locale//firstRun.json =

169 adblockplusui/locale//issue-reporter.json =	170 adblockplusui/locale//issue-reporter.json =

170 adblockplusui/locale//updates.json =	171 adblockplusui/locale//updates.json =

LEFT	RIGHT