Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/csp.js

Issue 29705719: Issue 6402 - Split filter hit / request logging out into own API (Closed)
Left Patch Set: Addressed Sebastian's feedback Created March 21, 2018, 3:14 p.m.
Right Patch Set: Addressed Manish's feedback Created May 9, 2018, 5:53 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Right: Side by side diff | Download
« no previous file with change/comment | « include.preload.js ('k') | lib/cssInjection.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
(no file at all)
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 "use strict"; 18 "use strict";
19 19
20 const {defaultMatcher} = require("../adblockpluscore/lib/matcher"); 20 const {defaultMatcher} = require("../adblockpluscore/lib/matcher");
21 const {RegExpFilter, WhitelistFilter} = 21 const {RegExpFilter, WhitelistFilter} =
22 require("../adblockpluscore/lib/filterClasses"); 22 require("../adblockpluscore/lib/filterClasses");
23 const {extractHostFromFrame, isThirdParty} = require("./url"); 23 const {extractHostFromFrame, isThirdParty} = require("./url");
24 const {checkWhitelisted} = require("./whitelisting"); 24 const {checkWhitelisted} = require("./whitelisting");
25 const {FilterNotifier} = require("filterNotifier"); 25 const {FilterNotifier} = require("filterNotifier");
26 const devtools = require("./devtools"); 26 const {logRequest} = require("./hitLogger");
27 27
28 const {typeMap} = RegExpFilter; 28 const {typeMap} = RegExpFilter;
29 29
30 browser.webRequest.onHeadersReceived.addListener(details => 30 browser.webRequest.onHeadersReceived.addListener(details =>
31 { 31 {
32 let url = new URL(details.url); 32 let url = new URL(details.url);
33 let parentFrame = ext.getFrame(details.tabId, details.parentFrameId); 33 let parentFrame = ext.getFrame(details.tabId, details.parentFrameId);
34 let hostname = extractHostFromFrame(parentFrame) || url.hostname; 34 let hostname = extractHostFromFrame(parentFrame) || url.hostname;
35 let thirdParty = isThirdParty(url, hostname); 35 let thirdParty = isThirdParty(url, hostname);
36 36
(...skipping 14 matching lines...) Expand all
51 let specificOnly = !!checkWhitelisted(page, frame, null, 51 let specificOnly = !!checkWhitelisted(page, frame, null,
52 typeMap.GENERICBLOCK); 52 typeMap.GENERICBLOCK);
53 if (specificOnly) 53 if (specificOnly)
54 { 54 {
55 cspMatch = defaultMatcher.matchesAny(details.url, typeMap.CSP, hostname, 55 cspMatch = defaultMatcher.matchesAny(details.url, typeMap.CSP, hostname,
56 thirdParty, null, specificOnly); 56 thirdParty, null, specificOnly);
57 if (!cspMatch) 57 if (!cspMatch)
58 return; 58 return;
59 } 59 }
60 60
61 devtools.logRequest([details.tabId], details.url, "CSP", hostname, 61 logRequest([details.tabId], {
62 thirdParty, null, specificOnly, cspMatch); 62 url: details.url, type: "CSP", docDomain: hostname,
63 thirdParty, specificOnly
64 }, cspMatch);
63 FilterNotifier.emit("filter.hitCount", cspMatch, 0, 0, [details.tabId]); 65 FilterNotifier.emit("filter.hitCount", cspMatch, 0, 0, [details.tabId]);
64 66
65 if (cspMatch instanceof WhitelistFilter) 67 if (cspMatch instanceof WhitelistFilter)
66 return; 68 return;
67 69
68 details.responseHeaders.push({ 70 details.responseHeaders.push({
69 name: "Content-Security-Policy", 71 name: "Content-Security-Policy",
70 value: cspMatch.csp 72 value: cspMatch.csp
71 }); 73 });
72 74
73 return {responseHeaders: details.responseHeaders}; 75 return {responseHeaders: details.responseHeaders};
74 } 76 }
75 }, { 77 }, {
76 urls: ["http://*/*", "https://*/*"], 78 urls: ["http://*/*", "https://*/*"],
77 types: ["main_frame", "sub_frame"] 79 types: ["main_frame", "sub_frame"]
78 }, ["blocking", "responseHeaders"]); 80 }, ["blocking", "responseHeaders"]);
LEFTRIGHT

Powered by Google App Engine
This is Rietveld