Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: metadata.chrome

Issue 29705719: Issue 6402 - Split filter hit / request logging out into own API (Closed)
Left Patch Set: Nightmarish rebase Created April 13, 2018, 3:20 p.m.
Right Patch Set: Addressed Manish's feedback Created May 9, 2018, 5:53 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/whitelisting.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 [general] 1 [general]
2 basename = adblockpluschrome 2 basename = adblockpluschrome
3 version = 3.0.2 3 version = 3.0.4
4 author = eyeo GmbH 4 author = eyeo GmbH
5 permissions = tabs
6 <all_urls>
7 contextMenus
8 webRequest
9 webRequestBlocking
10 webNavigation
11 storage
12 unlimitedStorage
13 notifications
14 backgroundScripts = polyfill.js 5 backgroundScripts = polyfill.js
15 ext/common.js 6 ext/common.js
16 ext/background.js 7 ext/background.js
17 lib/compat.js 8 lib/compat.js
18 lib/publicSuffixList.js 9 lib/publicSuffixList.js
19 lib/adblockplus.js 10 lib/adblockplus.js
20 testScripts = ../polyfill.js 11 testScripts = ../polyfill.js
21 ../ext/common.js 12 ../ext/common.js
22 ../ext/background.js 13 ../ext/background.js
23 ../lib/compat.js 14 ../lib/compat.js
24 ../lib/publicSuffixList.js 15 ../lib/publicSuffixList.js
25 tests.js 16 tests.js
26 options = options.html 17 options = options.html
27 devtools = devtools.html 18 browserAction =
28 browserAction = icons/abp-16.png icons/abp-19.png icons/abp-20.png icons/abp-32. png icons/abp-38.png icons/abp-40.png popup.html 19 icons/abp-16.png
29 icons = icons/abp-16.png icons/abp-32.png icons/detailed/abp-48.png 20 icons/abp-19.png
30 icons/detailed/abp-64.png icons/detailed/abp-128.png 21 icons/abp-20.png
31 managedStorageSchema = managed-storage-schema.json 22 icons/abp-32.png
23 icons/abp-38.png
24 icons/abp-40.png
25 popup.html
26 icons =
27 icons/abp-16.png
28 icons/abp-32.png
29 icons/detailed/abp-48.png
30 icons/detailed/abp-64.png
31 icons/detailed/abp-128.png
32
33 [manifest]
34 devtools_page = devtools.html
35 storage.managed_schema = managed-storage-schema.json
36 permissions =
37 tabs
38 <all_urls>
39 contextMenus
40 webRequest
41 webRequestBlocking
42 webNavigation
43 storage
44 unlimitedStorage
45 notifications
32 46
33 [compat] 47 [compat]
34 chrome = 49.0 48 chrome = 49.0
35 opera = 36.0 49 opera = 36.0
36 50
37 [contentScripts] 51 [contentScripts]
38 document_start = polyfill.js ext/common.js ext/content.js include.preload.js 52 document_start =
53 polyfill.js
54 ext/common.js
55 ext/content.js
56 include.preload.js
39 document_end = include.postload.js 57 document_end = include.postload.js
40 58
41 [mapping] 59 [mapping]
42 subscriptions.xml = adblockpluscore/chrome/content/ui/subscriptions.xml 60 subscriptions.xml = adblockpluscore/chrome/content/ui/subscriptions.xml
43 firstRun.html = adblockplusui/firstRun.html 61 firstRun.html = adblockplusui/firstRun.html
44 common.js = adblockplusui/common.js 62 common.js = adblockplusui/common.js
45 firstRun.js = adblockplusui/firstRun.js 63 firstRun.js = adblockplusui/firstRun.js
46 i18n.js = adblockplusui/i18n.js 64 i18n.js = adblockplusui/i18n.js
47 icons/detailed/abp-128.png = adblockplusui/skin/abp-128.png 65 icons/detailed/abp-128.png = adblockplusui/skin/abp-128.png
48 skin/common.css = adblockplusui/skin/common.css 66 skin/common.css = adblockplusui/skin/common.css
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 desktop-options.js = adblockplusui/desktop-options.js 133 desktop-options.js = adblockplusui/desktop-options.js
116 skin/desktop-options.css = adblockplusui/skin/desktop-options.css 134 skin/desktop-options.css = adblockplusui/skin/desktop-options.css
117 updates.html = adblockplusui/updates.html 135 updates.html = adblockplusui/updates.html
118 updates.js = adblockplusui/updates.js 136 updates.js = adblockplusui/updates.js
119 skin/updates.css = adblockplusui/skin/updates.css 137 skin/updates.css = adblockplusui/skin/updates.css
120 138
121 [bundles] 139 [bundles]
122 lib/adblockplus.js = 140 lib/adblockplus.js =
123 adblockpluscore/lib/filterListener.js 141 adblockpluscore/lib/filterListener.js
124 adblockpluscore/lib/synchronizer.js 142 adblockpluscore/lib/synchronizer.js
125 lib/devtools.js 143 lib/devtools.js
Manish Jethani 2018/04/23 15:30:59 Where is lib/hitLogger.js included?
kzar 2018/05/01 10:53:08 The modules listed here are "entry points" which W
Manish Jethani 2018/05/02 13:25:14 Acknowledged.
126 lib/requestBlocker.js 144 lib/requestBlocker.js
127 lib/popupBlocker.js 145 lib/popupBlocker.js
128 lib/subscriptionInit.js 146 lib/subscriptionInit.js
129 lib/filterComposer.js 147 lib/filterComposer.js
130 lib/stats.js 148 lib/stats.js
131 lib/uninstall.js 149 lib/uninstall.js
132 lib/csp.js 150 lib/csp.js
133 lib/cssInjection.js 151 lib/cssInjection.js
134 adblockplusui/messageResponder.js 152 adblockplusui/messageResponder.js
135 background.js 153 include.preload.js =
136 include.preload.js = include.preload.js inject.preload.js 154 include.preload.js
137 include.postload.js = subscriptionLink.postload.js composer.postload.js 155 inject.preload.js
156 include.postload.js =
157 subscriptionLink.postload.js
158 composer.postload.js
138 qunit/tests.js = 159 qunit/tests.js =
139 qunit/common.js 160 qunit/common.js
140 qunit/tests/prefs.js 161 qunit/tests/prefs.js
141 qunit/tests/url.js 162 qunit/tests/url.js
142 qunit/tests/cssEscaping.js 163 qunit/tests/cssEscaping.js
143 164
144 [import_locales] 165 [import_locales]
145 adblockplusui/locale/*/antiadblockInit.json = * 166 adblockplusui/locale/*/antiadblockInit.json = *
146 adblockplusui/locale/*/common.json = * 167 adblockplusui/locale/*/common.json = *
147 adblockplusui/locale/*/desktop-options.json = * 168 adblockplusui/locale/*/desktop-options.json = *
148 adblockplusui/locale/*/firstRun.json = * 169 adblockplusui/locale/*/firstRun.json = *
149 adblockplusui/locale/*/issue-reporter.json = * 170 adblockplusui/locale/*/issue-reporter.json = *
150 adblockplusui/locale/*/updates.json = * 171 adblockplusui/locale/*/updates.json = *
LEFTRIGHT

Powered by Google App Engine
This is Rietveld