lib/popupBlocker.js - Issue 29705719: Issue 6402 - Split filter hit / request logging out into own API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/popupBlocker.js

Issue 29705719: Issue 6402 - Split filter hit / request logging out into own API (Closed)

Patch Set: Fixed typo and exposed pageId for logged requests Created Feb. 22, 2018, 3:55 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/popupBlocker.js

diff --git a/lib/popupBlocker.js b/lib/popupBlocker.js

index 91f0f23d834249cdea7477caea9dc90d85b5aadb..dd4b8d6b7da0322143386d443a75d3390f4b3dc3 100644

--- a/lib/popupBlocker.js

+++ b/lib/popupBlocker.js

@@ -23,7 +23,7 @@ const {defaultMatcher} = require("matcher");

const {BlockingFilter, RegExpFilter} = require("filterClasses");

const {stringifyURL, isThirdParty, extractHostFromFrame} = require("url");

const {checkWhitelisted} = require("whitelisting");

-const {logRequest} = require("devtools");

+const {logRequest} = require("devLogger");

let loadingPopups = new Map();

« no previous file with comments | « lib/devtools.js ('k') | lib/requestBlocker.js » ('j') | no next file with comments »